search

tpope / vim-fireplace

fireplace.vim: Clojure REPL support
https://www.vim.org/scripts/script.php?script_id=4978
1.75k stars 139 forks source link

Add support for piggieback 0.3.1+ #311

Closed SevereOverfl0w closed 6 years ago

SevereOverfl0w commented 6 years ago

The new piggieback can be found at https://github.com/clojure-emacs/piggieback

They have dropped support for Rhino, as it was supported by a number of horrible hacks. Instead Nashorn is recommended as the default.

The old piggieback is still supported, and in the case you're using the old piggieback & don't have nashorn available, you can manually call out to rhino. The latest Clojure survey suggests that a large number of Clojure users do have nashorn available.

Nashorn definitely works as of this commit, so close #243

bbatsov commented 6 years ago

As one of the maintainers of piggieback I can that I feel this PR is the way to go. Rhino is a thing of the past and we should move forward (not to mention that the newer versions of piggieback also offer a nice performance boost).