search

tpope / vim-fireplace

fireplace.vim: Clojure REPL support
https://www.vim.org/scripts/script.php?script_id=4978
1.74k stars 139 forks source link

Show test progress after a short delay if tests are still running #349

Closed dhleong closed 5 years ago

dhleong commented 5 years ago

Another stab at getting #347 right. With this commit, we will always hide the quickfix window on success, and show it after 250ms if the tests are still running. 50ms was too fast on my machine; it may make sense to allow the delay to be customizable for slower machines.

With the "Started" message, the 250ms delay doesn't seem noticeable, but that may be subjective. And, on a quick success, the delay doesn't even come into play.

tpope commented 5 years ago

After sleeping on it a few days, I've decided that we should, in fact, close the quickfix window upon success. The idea of a configurable delay for the timer is giving me pause, are you still endorsing this change in light of mine?

dhleong commented 5 years ago

Not strongly. I also don't love having a configurable delay, but some people might need it; hard to say. The only benefit I can see from this version is that if you have a long-running test, you'll see the qf window popup with the status, which you'd only see on current master if that test had previously failed. Probably not worth the complexity of the timer.

The only thing I'm running into right now on the latest master is the "success" echo gets lost when you call RunTests multiple times in a row on a successful test set. Throwing a redraw in before the echo fixes it, for what it's worth.

tpope commented 5 years ago

I can't reproduce that. What's happening exactly? Are you seeing a Started: message?

dhleong commented 5 years ago

Yes, I see Started and possibly even Success flash, and then it goes away. It sticks around just fine if there's any redraw, like going from a fail to a success, or with a manual redraw call before the echo.

On Tue, Jul 16, 2019, 6:07 PM Tim Pope notifications@github.com wrote:

I can't reproduce that. What's happening exactly? Are you seeing a Started: message?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tpope/vim-fireplace/pull/349?email_source=notifications&email_token=AAGHIFUR4TVSVGIQ7F2NHQDP7ZBDXA5CNFSM4ICWTX7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2CJTLI#issuecomment-512006573, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGHIFRCNDO72B5XLBDTC6LP7ZBDXANCNFSM4ICWTX7A .

tpope commented 5 years ago

Redraw seems pretty benign so I added one.

dhleong commented 5 years ago

Looks great, thanks!