search

tpope / vim-fireplace

fireplace.vim: Clojure REPL support
https://www.vim.org/scripts/script.php?script_id=4978
1.74k stars 139 forks source link

[FIX] qualify "when-not" and "find-ns" with clojure.core #354

Closed mraveloarinjaka closed 5 years ago

mraveloarinjaka commented 5 years ago

Once connected to a repl, when trying to evaluate any form I get the error: "java.lang.RuntimeException: Unable to resolve symbol: when-not in this context"

tpope commented 5 years ago

Is this a error a recent development? Your change looks good but the fact this is happening after some recent refactoring makes me thing a weird bug (e.g., running in the wrong namespace) has been introduced.

mraveloarinjaka commented 5 years ago

I cannot pinpoint exactly when the issue appeared since I had not upgraded my plugins for a while before yesterday when I encountered the problem.

mraveloarinjaka commented 5 years ago

I am not familiar enough with vim scripting to debug that code. I will be interested in knowing what your workflow is to debug it. I can try to do a manual dichotomy if it helps.

tpope commented 5 years ago

Yeah a bisect would be great. Failing that, checking if it works on v1.2 or not would still be helpful.

mraveloarinjaka commented 5 years ago

Sorry for the late reply. First I would like to clarify the context where I encountered the issue: I am using fireplace in gvim running on a Windows 10 machine to hack on Clojure projects under wsl. I tried to reproduce the issue on another computer I that had an old Windows 10 update and an old Python version and I did not had the issue. I tried on my current computer (latest Windows 10 update and Python 3.7) and I consistently had the issue. I gave up trying to find the culprit commit because the feedback loop for a manual bisection was too long. I can confirm though that the merge was successful and the issue is fixed on my computer (and it is still not showing on the older one). Thank you.