search

tpope / vim-fireplace

fireplace.vim: Clojure REPL support
https://www.vim.org/scripts/script.php?script_id=4978
1.75k stars 139 forks source link

Compile-time errors swallowed with :Require #383

Closed frenchy64 closed 4 years ago

frenchy64 commented 4 years ago

Say we have a file foo.clj that doesn't compile:

(ns foo)
(nil)

Before https://github.com/tpope/vim-fireplace/commit/91e3b51294e61e36632bfc0bda1f5b2be4dc5c6d, calling :Require would result in this error:

Error detected while processing function <SNR>68_Require[19]..function <SNR>68_Require[13]..fireplace#eval:
line   63:
E121: Undefined variable: response

Perhaps https://github.com/tpope/vim-fireplace/commit/91e3b51294e61e36632bfc0bda1f5b2be4dc5c6d was intended as the fix for this, but the new behavior seems to silently swallow compile-time errors.

The error is retrievable via :Last, but :Require does not throw the error itself.

I can also reproduce on the current HEAD (https://github.com/tpope/vim-fireplace/commit/a465d598b23b4fa04f0cd61895918cca498f1c9b).