`:Last` is not updated on error

tpope / vim-fireplace

fireplace.vim: Clojure REPL support

https://www.vim.org/scripts/script.php?script_id=4978

1.75k stars 139 forks source link

`:Last` is not updated on error #393

Closed frenchy64 closed 3 years ago

frenchy64 commented 3 years ago

When an evaluation succeeds, :Last is idempotent (the same window that popped up is used to display the result).

But when it fails (eg., with an exception), the previously opened :Last buffer is not updated, and I have to call :Last again to "refresh" the buffer and see the new printed error.

frenchy64 commented 3 years ago

I need to check if this is related to missing middleware before investigating further...

frenchy64 commented 3 years ago

After reading the code, I think the catch clause of fireplace#echo_session_eval might be a good place to add this functionality.

frenchy64 commented 3 years ago

Seemed to work: https://github.com/tpope/vim-fireplace/pull/395