`zipfile:` -> `zipfile://` to fix jump to definition issues due to pi_zip v32 changes

tpope / vim-fireplace

fireplace.vim: Clojure REPL support

https://www.vim.org/scripts/script.php?script_id=4978

1.75k stars 139 forks source link

`zipfile:` -> `zipfile://` to fix jump to definition issues due to pi_zip v32 changes #398

Closed philomates closed 2 years ago

philomates commented 2 years ago

currently jump to definition is broken due to zipfile:/home/me/foo.jar::file.clj not opening in vim.

looking at :help zip I found that v32 of pi_zip has changed:

   v32 Oct 22, 2021 * to avoid an issue with a vim 8.2 patch, zipfile: has
                      been changed to zipfile:// . This often shows up
                      as zipfile:/// with zipped files that are root-based.

Note that I'm unsure how this change works with earlier versions pi_zip's zipfile

tpope commented 2 years ago

The paint is still wet on this change; backwards compatibility is mandatory. A check like get(g:, 'loaded_zipPlugin')[1:-1] > 31 might work.

philomates commented 2 years ago

your tip seems to work for me and I also tested flipping the conditional to double check the old behavior is preserved (as in, it breaks on my setup)