search

tpope / vim-fugitive

fugitive.vim: A Git wrapper so awesome, it should be illegal
https://www.vim.org/scripts/script.php?script_id=2975
20.01k stars 1.01k forks source link

Git difftool does not work with `--check` #2303

Closed lakshayg closed 5 months ago

lakshayg commented 5 months ago

When I call :Git difftool --check, the quickfix list is populated but the entries don't jump to files. I would expect it to behave similar to:

:let old=&makeprg | set makeprg=git\ diff\ --check | make | let &makeprg=old

I suspect there's some issue with the 'errorformat' but I couldn't figure out how to set it in the plugin code.

lakshayg commented 5 months ago

Thanks for working on this! I found a small error when testing it locally and made a PR to fix it: https://github.com/tpope/vim-fugitive/pull/2305