tpope / vim-fugitive

fugitive.vim: A Git wrapper so awesome, it should be illegal
https://www.vim.org/scripts/script.php?script_id=2975
20.07k stars 1.01k forks source link

[bug] `'<,'>GBrowse` attaches `%5C` in URL before the `#` character #2354

Open embe221ed opened 1 week ago

embe221ed commented 1 week ago

after this commit, and because of this line the # character used to point to a specific line/range of lines is escaped, causing the opened URL to look like this: <path_to_file>%5C#<lines> which results in 404 Not Found error. Confirmed this by removing the escape() call from the mentioned line and re-building neovim

tpope commented 2 days ago

A possible fix would be to use netrw#Open() if available, and update the escaping to match. That way older versions of Vim can still work with the old behavior of netrw#BrowseX().