Closed chrisbra closed 2 years ago
This plugin is dead, so I'm opting not to dirty the history with a bunch of fold markers.
I understand. thanks anyhow for removing the modeline expression.
I understand. thanks anyhow for removing the modeline expression.
He took your change and put his name on it, FYI: https://github.com/tpope/vim-pathogen/commit/ac4dd9494fa9008754e49dff85bff1b5746c89b4
It's not the same change. This PR changed foldmethod
to marker
while my commit removed it entirely. Also did you miss the part where he thanked me?
I'm referring to the following, where the only difference I see is a :
, though I'm unfamiliar with the codebase:
I noticed this on another PR that was closed on another project, where you did the same thing. Admittedly they're both fairly minor changes.
I didn't notice it was 2 commits, but even if I had, I probably would have done the same thing anyways, as it's still not the same change: Mine has a trailing colon, which is my preferred modeline style.
... Disregarding the ridiculous drama above about "properly crediting" a one-character change that:
:expressionless:
I've been relying on Pathogen to load my vim stuff for 11 years. So I feel justified to publically voice a comment of dissent, perhaps dispelling a "silent majority" style of situation.
This plugin is dead
@tpope tremendous thanks for writing, publishing, maintaining pathogen
all these years :pray: And for keeping discussion open regardless of reaching stability.
I have been, and will continue, using multiple Vim things you've made.
As a user, it's great to have definite maintenance policy, even if it is "This plugin is dead" — so further thanks, for unambiguously expressing that.
It won't stop me from continuing to use pathogen
though. I do occasionally reevaluate, but still have my reasons to not migrate off onto other implementations.
And after all, directly and indirectly I am already a daily user of heaps of software written by now-deceased people. Most direct and immediate example is Vim itself.
Because software doesn't really die.
Vim disabled by default
*expr
settings in the modeline in https://github.com/vim/vim/commit/110289e78195b6d01e1e6ad26ad450de476d41c1 While one could set the 'modelineexpr' setting, it's not recommended for security reasons.So remove setting a custom fold expression from autoload/pathogen.vim and revert back to a foldmethod=marker folding from f66e6f483fea8fef90a534053be30d1e79a19711