search

tpope / vim-rails

rails.vim: Ruby on Rails power tools
http://www.vim.org/scripts/script.php?script_id=1567
4.1k stars 383 forks source link

Some version of Vim this year broke the use of range with `:'<,'>Rails` #549

Closed emilyst closed 4 years ago

emilyst commented 4 years ago

Sometime earlier this year (I wanna say in spring?), the use of the default :Rails command using a range broke.

The behavior before was that, in a spec file (for example), I could select a line and type :'<,'>Rails, upon which it would pass that to the spec runner. This behavior is intact in Vim 8.0.1365 (default on Mojave).

On Vim version 8.1.2100 (from Homebrew), running that command gives the error message, E16: Invalid range.

I made some considerable effort to bisect the vim-rails and vim-projectionist and vim-dispatch plugins to discover if they had a regression. I could not find one. This appears to be a change in Vim itself. I cannot for the life of me figure out which patch caused this or what the actual problem is. Sorry about that.

tpope commented 4 years ago

In the same ballpark as https://github.com/tpope/vim-scriptease/issues/43 and https://github.com/tpope/vim-fugitive/issues/1358. These backwards incompatible changes are very out of character; not sure what the story is there.

This particular case is a rather awkward use of -count that needed to be cleaned up anyways, so no loss there.

emilyst commented 4 years ago

In the same ballpack as tpope/vim-scriptease#43 and tpope/vim-fugitive#1358. These backwards incompatible changes are very out of character; not sure what the story is there.

This particular case is a rather awkward use of -count that needed to be cleaned up anyways, so no loss there.

Tough but fair.