search

tpope / vim-repeat

repeat.vim: enable repeating supported plugin maps with "."
http://www.vim.org/scripts/script.php?script_id=2136
2.59k stars 81 forks source link

Pass flag 'i' to feedkeys() call #39

Closed wellle closed 9 years ago

wellle commented 9 years ago

Similar to #36, fixes #23 by passing the new flag 'i' to feedkeys() that is available since Patch 7.4.601.

I also tested on Vim 7.3 to ensure compatibility. The unknown flag 'i' is just silently ignored. So we don't need any version checks here.

tpope commented 9 years ago

But this introduces a regression for Vim versions between 7.3.100 and 7.4.600, no?

wellle commented 9 years ago

True, but only for those users that updated your plugin in the last nine days.

But I agree, for those we might want to keep the :norm fallback. Will update.

wellle commented 9 years ago

Updated.

wellle commented 9 years ago

@tpope: Anything else that needs to be done here?

tpope commented 9 years ago

I was made wary by Ingo Karkat's comment, but since it seems to have been deleted I guess I'll give it a try.

inkarkat commented 9 years ago

I tended to favor :normal, but as has been mentioned in another issue, that causes ugly multiline errors in case the repeat fails. (Which could be avoided, but not without a large restructuring.)

I think the new handling is the best trade-off, using the i flag if supported, and :normal (with not so nice errors) for older versions.