tpope / vim-repeat

repeat.vim: enable repeating supported plugin maps with "."
http://www.vim.org/scripts/script.php?script_id=2136
2.62k stars 83 forks source link

Publish tagged releases to LuaRocks.org #96

Closed mrcjkb closed 5 months ago

mrcjkb commented 1 year ago

Summary

This PR is part of a push to get (neo)vim plugins on LuaRocks.

Things done:

Notes

I have tested this with the quick-scope plugin in Neovim using the following minimal config:

mkdir /tmp/nvim-test
luarocks install --tree /tmp/nvim-test quick-scope
cd /tmp/nvim-test
nvim minimal.lua # paste minimal.lua below
nvim -u minimal.lua test.txt
-- minimal.lua

-- Ignore default config
local config_path = vim.fn.stdpath('config')
vim.opt.rtp:remove(config_path)

-- Ignore default plugins
local data_path = vim.fn.stdpath('data')
local pack_path = data_path .. '/site'
vim.opt.packpath:remove(pack_path)

vim.opt.runtimepath:append('lib/luarocks/rocks-5.1/quick-scope/scm-1/')

...and it works :tada:

image

Adding the API key (screen shot) github-add-luarocks-api-key

mrcjkb commented 5 months ago

I've added repeat.vim to the NURR.

tpope commented 5 months ago

Meant to circle back on this.

In fact, as a popular plugin that many other plugins depend on,

The plugin is quirky enough that I would discourage a hard dependency actually, some users might want to opt out. If there's something like "recommends" or "suggests" or "optional dependency", that would make more sense.

having vim-repeat on LuaRocks.org could be great for further adoption.

Using luarocks feels like, at best, a solution for Neovim. It doesn't feel like a good solution for Vim, which my plugins also support. So it's not a solution I would say I'm enthusiastic about, and thus I don't really want to play an active part in incentivizing "further adoption".

If you support this, please let me know if you would like me to add equivalent PRs to your other plugins.

If it became a de facto standard, I might pragmatically participate. Until then, I will be sitting it out.