Closed mrcjkb closed 5 months ago
Meant to circle back on this.
In fact, as a popular plugin that many other plugins depend on,
The plugin is quirky enough that I would discourage a hard dependency actually, some users might want to opt out. If there's something like "recommends" or "suggests" or "optional dependency", that would make more sense.
having
vim-repeat
on LuaRocks.org could be great for further adoption.
Using luarocks
feels like, at best, a solution for Neovim. It doesn't feel like a good solution for Vim, which my plugins also support. So it's not a solution I would say I'm enthusiastic about, and thus I don't really want to play an active part in incentivizing "further adoption".
If you support this, please let me know if you would like me to add equivalent PRs to your other plugins.
If it became a de facto standard, I might pragmatically participate. Until then, I will be sitting it out.
Summary
This PR is part of a push to get (neo)vim plugins on LuaRocks.
luarocks
from being able to package this :smile: In fact, as a popular plugin that many other plugins depend on, havingvim-repeat
on LuaRocks.org could be great for further adoption.Things done:
Notes
neovim
and/orvim
labels have to be added to the LuaRocks package manually (after the first upload), for this plugin to show up in https://luarocks.org/labels/neovim or https://luarocks.org/labels/vim, respectively.I have tested this with the
quick-scope
plugin in Neovim using the following minimal config:...and it works :tada:
Adding the API key (screen shot)