tpope / vim-rsi

rsi.vim: Readline style insertion
http://www.vim.org/scripts/script.php?script_id=4359
583 stars 35 forks source link

Options for disabling meta maps in insert and/or command mode #26

Closed sim590 closed 4 years ago

sim590 commented 9 years ago

At first, I've noticed that I couldn't insert î character and then, I've noticed that people had put issues about some other characters that couldn't be inserted such as ä. The thing is that I like this plugin only for the meta maps inside the command mode so I can edit my command faster. That's why I've implemented some options to disable insert mode meta maps. I thought that adding the option for disabling command mode meta maps wasn't that hard either, so I put it in. People don't really put special UTF-8 characters inside a command so the option for disabling the command mode meta maps may be irrelevant. That's why I've seperated the implementation of both in seperate commits so all of the modifications could be cherry-picked.

I hope those changes can be appreciated and merged !

Cheers !

rosshadden commented 9 years ago

This is a great idea. I keep going back and forth between turning off insert mode mappings, which makes macros work properly, and enabling them so I can benefit from the meta commands in cmd mode. This PR will allow me to leave only insert-mode bindings disabled.

Thanks!

obxhdx commented 9 years ago

This is very useful indeed. I'm used to hit C-a in insert mode in order to insert previously inserted text. Any chance you're gonna merge this, @tpope?

justinmk commented 9 years ago

@obxhdx I don't think this PR is going to help with C-a. Are you aware of <C-R>.?

obxhdx commented 9 years ago

@justinmk Oh, thanks for sharing that. I overlooked the commits from the PR and thought all insert mappings were being disabled. <C-R>. surely helps, but <C-a> is one less keystroke, so I think I'll create my own fork.

tpope commented 9 years ago

You could unmap it in an after file or a VimEnter autocommand, but sure, the power of open source means I can't stop you from creating a fork, changing one line, and abandoning it.

Not every damn petty grievance needs an option.

tpope commented 9 years ago

(BTW the original request sounds more within the realm of consideration, but it doesn't meet commit message guidelines so I haven't looked at it.)

sim590 commented 9 years ago

@tpope : I've addressed the issue about commit messages following guidelines found at http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html. I hope it's okay. I didn't know about those.

srcehmar19 commented 9 years ago

thank you very much!

sim590 commented 6 years ago

@tpope: This PR is really old, but thankfully the project doesn't move too much either :wink:. Can we merge this? I think that the last changes asked were provided. Tell me if there's anything else.

I have squashed all commits into one.

sim590 commented 5 years ago

I came across this PR again and I checked the commit message and realized I didn't put a capitalized letter at the beginning. I just did now. I hope that this is now OK. After three years, may be this could be merged.