search

tpope / vim-rvm

rvm.vim: Switch Ruby versions from inside Vim
http://www.vim.org/scripts/script.php?script_id=4269
117 stars 5 forks source link

rvm#buffer_path_identifier Fix #3

Closed dhruvasagar closed 11 years ago

dhruvasagar commented 11 years ago

In case we were in a deep nested file, the rvm tools path-identifier api returned both the path along with the ruby version information, I have corrected the same by spliting the return string and the returning the last item in the list which is the ruby version information.

dhruvasagar commented 11 years ago

Any comments on this ?

tpope commented 11 years ago

Could you give that = some breathing room, drop the comment (it's not really a workaround unless you consider RVM's behavior to be a bug), and squash it into one commit with an imperative commit message?

dhruvasagar commented 11 years ago

That's what I am talking about! I will work on that :+1:

dhruvasagar commented 11 years ago

A point regarding the comment, well this was specifically the case only for files that are deep, for files on the root it worked fine, that's why I used [-1], so that in case it's the right result, I still select the right value.

dhruvasagar commented 11 years ago

Hey Tim, I hope this is better now.

tpope commented 11 years ago

Thanks!

dhruvasagar commented 11 years ago

:+1: