search

tposney / dnd5e-scriptlets

Various Bits and pieces for dnd5e
Other
4 stars 2 forks source link

Ammunition Selector with support to Ready Set Roll #7

Closed eduardopato41 closed 11 months ago

eduardopato41 commented 11 months ago

Hello! I know this is really not a issue as this is not a module made to work with other modules but...

For my next campaign I gonna try to use the default character sheet instead of Tidy5e and this module looks like the perfect alternative to some of the things that made me use tidy in the first place. Incredible work!

The thing is, my players really like RSR and we're all brazilians playing in Portuguese (BR). I was able to edit the js file (ammo-selector.js) for ammunition autoselect and when there's only 1 type of ammo everything works fine. If there's 2 or more the dialog for selection appears fine but when I select a option the dialog closes but nothing happens (with RSR enabled). There's no console error, only a "Foundry VTT | Rendering Dialog" message. And I'm not a dev to edit the module :(

Is there a simple way to them both work together? Or the better way to resolve this is to ask help on the Discord? Thanks!

tposney commented 11 months ago

I've had a look and as of 0.15 ammo selector works with RSR. I've only tested it with English but I hope it won't make a difference.

eduardopato41 commented 11 months ago

Just tested and it's working great. Thank you very much, @tposney!