search

tposney / midi-qol

Other
5 stars 0 forks source link

Redundant card when using Monks Token Bar as prompt for saves #1054

Open tposney opened 2 years ago

tposney commented 2 years ago

In GitLab by @cassnotablet on Nov 1, 2022, 20:24

When using Monks Token Bar as prompt for saves the results will be posted twice, once from midi and once from Monks Token Bar. This is redundant and if there are 3 or more creatures making the saves it fills a lot of the chat making it annoying to scroll if one wants to read the spell again.

I think that Monks Token Bar's card should be deleted after the results are processed, if possible.

tposney commented 2 years ago

I'm not seeing that behaviour. Can you export your midi settings (from the misc tab)- I can't do any diagnosis without them.

tposney commented 2 years ago

In GitLab by @cassnotablet on Nov 2, 2022, 24:42

fvtt-midi-qol-settings_1.json

I tried this with only the necessary modules. When I re-log after after the roll the most recent Monks Token Bar is not there but the previous ones are. I am using The Forge for hosting.

tposney commented 2 years ago

still can't repro the problem. Is it a player or a GM rolling the item that causes the save and is it a player or GM that controls the target of the attack?

tposney commented 1 year ago

In GitLab by @Bedrydant on Nov 30, 2022, 09:30

MidiQoLMonksTokenBarSaveIssue fvtt-midi-qol-settings.json

This is the Issue we are talking about and those are my settings.

Steps to reproduce:(as a GM)

Drop an Aoe Spell over a bunch of Npcs

Monks TokenBar promps, roll all the saves

Then the success confirmation is generated becoming redundant with the TokenBar card

tposney commented 1 year ago

Ok, now I understand. My first thought is that it's not going to change from current. The monk's card does not display success failure for the rolls, just the roll result. Also, the save results card (the midi-qol one) include results for auto rolled saves as well as LMRTFY saves.

It might be possible to remove the monks card when all the saves are complete. I'll have a look at that.

tposney commented 1 year ago

In GitLab by @Bedrydant on Nov 30, 2022, 10:50

The only problem with that could be the loss of the selection options at the bottom of Monk's card So maybe could be an option on Midi-QoL to hide that information from the GM? just like the players side when "Only GM sees" is chosen

tposney commented 1 year ago

Hiding from the GM would not be good as it would cause problems when the GM controlled actors need to do a monk's save.