search

tposney / midi-qol

Other
5 stars 0 forks source link

[bug] Vitality resource not taking damage #1194

Open tposney opened 1 year ago

tposney commented 1 year ago

In GitLab by @joshualucasfern on Mar 12, 2023, 13:41

I have set the vitality resource as both primary and as fourth, in neither case was damage transferred from the character to that resource. I used both @resources.primary/@resources.fourth and resources.primary/resources.fourth, neither syntax worked.

Screenshot_2023-03-11_195119

tposney commented 1 year ago

Syntax is system.resouces.primary.value like the example in the changelog

tposney commented 1 year ago

IF that does not fix the problem please reopen the issue

tposney commented 1 year ago

In GitLab by @joshualucasfern on Mar 15, 2023, 15:39

Screenshot_2023-03-14_223509

Tested with these settings, still no damage to the primary resource. tested without the resource expansion module as well. The tested attack is a reaction attack, and the player being attack does have a reaction response that is prompted if that could interfere with things. I'm going to test on a fresh world here in the next couple days.

tposney commented 1 year ago

In GitLab by @joshualucasfern on Mar 15, 2023, 15:41

Screenshot_2023-03-14_224059

tposney commented 1 year ago

Can you send me the actor that should take vitality damage? Always easier to test with an actual actor. Also add your midi settings (export from the misc tab)

tposney commented 1 year ago

I just realised that the vitality pool is ONLY used if the damage is applied via one of midi-qols ways of applying damage, either the automatic application, or using the chat card buttons.

If you just decrement the hitpoints on the character sheet it won't work. I'll have to fix that.

tposney commented 1 year ago

In GitLab by @joshualucasfern on Mar 15, 2023, 18:20

I was using an attack with automated damage turned on. I'll add my midi setting here in a minute. I tested on two different actors.

... On Tue, Mar 14, 2023, 23:36 Tim Posney (@tposney) wrote: > Tim Posney commented > : > > I just realised that the vitality pool is ONLY used if the damage is > applied via one of midi-qols ways of applying damage, either the automatic > application, or using the chat card buttons. > > If you just decrement the hitpoints on the character sheet it won't work. > I'll have to fix that. > > — > Reply to this email directly or view it on GitLab > . > You're receiving this email because of your account on gitlab.com. > Unsubscribe > > from this thread · Manage all notifications > · Help > >
tposney commented 1 year ago

In GitLab by @joshualucasfern on Mar 15, 2023, 20:22

fvtt-midi-qol-settings.jsonfvtt-Actor-ka_ren.json

tposney commented 1 year ago

It was a typo on my part I put "system.resouces.primary.value" and it should have been "system.resources.primary.value", also you had a space in the field name at the end (I'll put in a fix for that). And you should be able to use system.resources.fourth.value I think.

After the fix it seems to be working as expected.