search

tposney / midi-qol

Other
5 stars 0 forks source link

[10.0.35] - reintroducing flags.midi-qol.optional.NAME.criticalDamage #1221

Closed tposney closed 1 year ago

tposney commented 1 year ago

In GitLab by @thatlonelybugbear on Apr 6, 2023, 12:44

This is an issue for the discord comment: https://discord.com/channels/170995199584108546/1010273821401555087/1090600855335616572

This flag is commented out.

I tried to put it back in, with relevant success.

It works if:

  1. flags.midi-qol.optional.NAME.criticalDamage | Custom | true,false,1,0,whatever where the Effect value needs to be just NOT empty 🤷 and
  2. it needs a damage roll of some kind, eg. flags.midi-qol.optional.NAME.damage.all | Custom | 1d4.

Then if the Attack Roll is a critical hit, it will successfully double up the damage dice.

But the damage card will have its details a bit messed up.

The weapon's critical damage roll (1d4 doubled in this case) will be shown just as the total damage and no DSN roll.

The optional damage roll (1d6 doubled in this case) details will be shown though and DSN will roll too.

crit

tposney commented 1 year ago

Had a play with this. Will go out in 10.0.38