tposney / midi-qol

Other
5 stars 0 forks source link

[BUG] LMRTFY-based saves result in multiple prompts per save. #1239

Open tposney opened 1 year ago

tposney commented 1 year ago

In GitLab by @Gambet on May 2, 2023, 02:12

This issue does not seem to be present in 10.0.36 of MidiQOL, but I think it was introduced around .37 or .38.

When Dice So Nice, MidiQOL, and Let Me Roll That For You are installed, and Midi's Save Prompts are set to LMRTFY + Query, all saves generated from items, such as a Spell or an Attack that requires a saving throw, results in multiple prompts for that save. How many required seems random, although it also seems like it asks for more the more you repeat the use of an item. At first an item only asked for 3 duplicate saves, but after I used the same item against the same token several times, it was asking me for the one save 7 times. I don't know if it would have kept increasing the number over time.

There are no errors involved in this. Disabling Dice So Nice seems to fix the bug, but I'm 99% sure the bug is introduced by MidiQOL, as rolling Midi back to 10.0.36 fixes the bug, even with LMRTFY being fully updated.

tposney commented 1 year ago

I can't seem to repro this, can you export your midi settings (from the misc tab) and attach them here

tposney commented 1 year ago

In GitLab by @Gambet on May 2, 2023, 15:06

fvtt-midi-qol-settings.json

Here you go

tposney commented 1 year ago

I've tried with your settings and I can't repro the problem. The only thing I can think of is to connect to your world and try and see what is going on.