tposney / midi-qol

Other
5 stars 0 forks source link

Chat Card Optimization: Remove seperate d20 modifier div #1247

Closed ZeroXNoxus closed 7 months ago

ZeroXNoxus commented 8 months ago

The additional div only displaying the modifier added to the d20 roll seems unnecessary, especially when compared to the damage roll and the way those modifiers are displayed (merged chat card): 316335206-ae7d9fb2-09e9-4975-b027-37781d7c163f

tposney commented 7 months ago

Firstly this is not the active midi-qol repository - you want gitlab.com/tposney/midi-qol. This is just me testing migration from gitlab to git hub.

The extra div is due to how dnd5e renders attack rolls - try rolling with midi disabled and you'll see the same behaviour. Since I rely on dnd5e to render the attack roll tooltip this is probably not going to change.