search

tposney / midi-qol

Other
5 stars 0 forks source link

Enchantments not respecting unchecked "Apply to self when item applies to target effects" flag #1250

Open Galphanore opened 5 months ago

Galphanore commented 5 months ago

If you create an enchantment with a secondary effect, when you use the enchantment the secondary effect is transferred to the actor holding the now enchanted object regardless of whether the "Apply to self when item applies to target effects" flag is checked.

Once the enchantment is in effect, the flag works properly, but as the enchantment is first cast it should not be applied to the actor. In the below enchantment, it adds psychic damage to the weapon (which works fine) and the secondary effect applies "Fear" on hit. Right now, no matter what I do, as the spell is cast the person holding the weapon gets hit with Fear. After that, the people they attack are ALSO targets of fear.

ApplyToSelf

Vengeful

VengefulFear

tposney commented 5 months ago

It turns out you picked exactly the right edge case for DAE to fail.

DAE is not checking for item effects being non-transfer effects and so is applying the macro.XXX type of conditions. Fix in the next DAE release.

tposney commented 5 months ago

Should also mention that those flags are only relevant when the effect is being applied to a target actor (after being added to the item and the item is used), not when applied as an enchantment.