Feature Request - "Merge Rolls to one card" have some stylish problem if we clicked the damage button before the attack button

[tposney]

In GitLab by @p4535992 on Aug 23, 2020, 21:01

Environment Details

Foundry VTT Version: 0.7.1

Operating System: [Linux]

How Are You Using Foundry: [Linux,Native Application (Electron), Chrome]

Which Game System: Dungeons and Dragons 5th Edition, version 0.95

Modules Enabled?: yes

OS, Hosting, Browser (if applicable): Linux/Node/Chrome

Module Version : 0.2.3

Description of the issue:

It's happening!!!! some player click on the damage button before click on the attack button.

These are the steps for the behavoiur of the current issue:

1) Go to settings of the module 2) Enable the checkbox for "Merge Rolls to one card" 3) Click on the damage button before click on the attack button

Here the screenshot of the issue the first image is when we clicked attack and damage, the second images is when we clicked damage and attack:

A possible solution can be let the damage button disabled until you haven't clicked the attack button possibly with another settings (because can be useful in other use cases)

Another things if i enable "Add damage buttons to chat message" while i enable "Merge Rolls to one card" the buttons doesn't show up.

[tposney]

First, thanks for the highly detailed bug reports, it is such a pleasure to be able to follow exactly what is going on.

I had never considered the case that someone might roll damage before rolling attack (no real reason that they shouldn't). In fact the behaviour you are seeing is more than cosmetic. Rolling the damage complete the roll and the attack roll is ignored by the module.

I will disable the damage button until the attack roll is done.