Dice so Nice handling incorrectly hiding save results

[tposney]

In GitLab by @mejari on May 31, 2021, 05:38

• FVTT version: 0.7.10
• Midi-QOL version: 0.3.103
• DsN version: 3.3.4
• System: DND5e 1.2.4
• Step to reproduce:
  1. Enable midi-qol and Let Me Roll That For You modules in addition to DsN
  2. Enable Midi-qol roll automation, set Auto Check Saves to "Save - only GM sees" and Prompt Players to Roll Saves to "Let me Roll That For You"
  3. Use an ability on a token that requests a roll from a player.
  4. Player clicks to roll the requested check
• Result: The roll is added to the log
• Expected Result: The roll is added to the log and a separate, GM only, log message shows if they succeeded or failed, in the form "Character Name fails with #"

When I disable DsN it works as expected, enabling it causes the results log entry not to be shown. If I refresh the application/browser the entry to appear in the log history correctly.

Digging into the codebase it seems in the DsN handling code in chatMesssageHandling.ts:172 there doesn't seem to be any distinction between cards that are and are not rolls. This causes the saving throw results card to be hidden by the html.hide() call, but DsN (correctly) does not see any rolls in the message so it never fires the corresponding diceSoNiceRollComplete that Midi-QOL would use to unhide the message.

Not sure if it breaks anything else or has unintended side-effects but I copied DsN's check for if the message contains a roll into the diceSoNiceHandler function:

let hasInlineRoll = game.settings.get("dice-so-nice", "animateInlineRoll") && message.data.content.indexOf('inline-roll') !== -1;
if (!message.isRoll && !hasInlineRoll) {
    return;
}

and that seemed to at least get the saving throw summary card to appear.

[tposney]

Thanks for the report. I've got a couple of questions. I just tried in my 0.8.6 world and can't repro - which usually means I've missed out some setting that you are using that did not occur to me.

Who is triggering the attack GM or player? Can you confirm you workflow settings, combined card or separate? (Perhaps send me all of the settings on the workflow tab) and any DSN settings that might be relevant. (I don't use it so am not super up to date on it).

I tried with both combined card and separate and in all cases the who saved card is displayed for me.

I have not looked at the DSN code for quite some time so it is entirely possible that there are errors in that regard - but I'd like to be able to reproduce the problem.

[tposney]

In GitLab by @mejari on Jun 2, 2021, 03:32

Thank you for checking it out!

I've tried it with both the GM and the player triggering the attack (using a fireball that places the template, then rolling damage). It behaves the same whether it's an NPC or an offline PC that is getting auto-rolled for.

I'm running it with these modules:

Here are all my module settings:

And here are the midi-qol workflow settings:

[tposney]

Sorry for the delay in getting back to you. I just retested in 0.8.19 and it seems to be working as expected. If not please reopen this report.

[tposney]

In GitLab by @mejari on Jun 21, 2021, 04:44

Hey, sorry, tested again and had the same issue with the latest version but then realized you said 0.8.19. I'm having trouble finding that version, the latest I see available is 0.8.18. Is there somewhere I can grab it to test? Thanks!

[tposney]

I a dolt and the 0.8.19 release I mentioned did not go out as planned but is there now.

[tposney]

In GitLab by @mejari on Jun 21, 2021, 16:52

Great, thank you. Unfortunately the issue seems to still be there in 0.8.19. I've attached the new settings export json.fvtt-midi-qol-settings.json

[tposney]

I've tried again with the settings you use imported and I cannot reproduce the problem. Can you export the actor initiating the action, the target actor and also let me know what action is being performed? The saves card should get triggered when the player save is displayed, which is what I am seeing.

Also can you share your dice so nice settings?

[tposney]

In GitLab by @mejari on Jun 24, 2021, 05:27

I get the same results no matter what actor I'm using. Here is a test actor I just created that has the broken behavior when I cast Fireball from it. TestActor.json

Aaah, now this is interesting. I'm verifying behavior with different targets. Creating an empty test actor as the target causes the roll to work! If any actor that's been imported using the DDB importer is included in the targets then the roll results message doesn't appear. (Could be something else, but that's the only thing I can see that the actors have in common)

Here's one of the PCs I've imported from DDB that causes the message to not show up: BrokenActor.json

Sorry I didn't figure that out earlier. Presumably something in the structure of the actor gets messed up? There still aren't any errors onscreen or in the console so I don't know what might be causing the problem. Strangely the little if-block I gave in the original bug report solves the problem for me, but now I'm not really sure why.

I gave the main DSN settings in the first comment, here are the user-specific settings. I don't think I changed any of them from default.

[tposney]

Sorry for the delay in getting back to you. There definitely seems something wrong with the "broken" actor. When I import it, the import runs, but there are errors and if I refresh foundry all spells/equipment on the actor disappear.

If I cast a spell before doing the refresh I can reproduce your issue, but I think it is actually a side effect of the actor being very broken.

If I refresh (so all the actor's spells disappear) and then add (for example) fireball all works as I would expect.

Can you do me a favour, when rolling the spell with the save from the broken actor can you check the developer console log for errors - I was seeing lots when I rolled from the actor, but would be interested to see what you are getting.

[tposney]

Also worth importing those actors from the exports you sent to see if you get the same errors.