search

tposney / midi-qol

Other
5 stars 0 forks source link

Choose how to roll critical damage #380

Open tposney opened 3 years ago

tposney commented 3 years ago

In GitLab by @ajscott860 on Jun 13, 2021, 06:49

Hello. Is there an issue with this option in Midi-Qol? Does not seem to be working since I updated to .0.8.6 VTT and updated all modules. Here are a couple of screenshots. The math does not make sense but it doesn't seem to be doing as desired.

Crit-Config Crit-Roll

tposney commented 3 years ago

In GitLab by @ajscott860 on Jun 27, 2021, 05:06

Seems to still be working as seen above. Anyone else see this in their games?

tposney commented 3 years ago

What I would expect to see is 1d6min6, and am not sure why there are to mins in the roll expression. What midi does is silently upgrade the rolls to the max of the roll. So 1d6min6 means roll a six, the damage display will show whatever you rolled but the result will be max possible, in this case 6. Form the display you sent (other than the duplicated mins) it seems to be doing the right thing.

If you can export the item to json and send it to me I can have a look

tposney commented 3 years ago

In GitLab by @ajscott860 on Jul 1, 2021, 09:51

Pictured here is a critical hit. It rolled one D6 and got a 2. So I would guess max normal damage would be 6 then add the +2 from the D6 that was rolled for a total of 8. Yet the total damage only equals 6 in this roll? Not sure how to export the item to json? This basically was observed with different players and weapons.

Crit-roll-2

tposney commented 3 years ago

In GitLab by @ajscott860 on Jul 1, 2021, 09:55

Here is a different weapon. I would think the total damage here should equal 19 yet somehow it comes up with 16. Wouldn't the normal dice be a 1d8 maxed to 8 and a 1d4 maxed to 4, then one extra of each are rolled and added to the total?

Crit-roll-3

tposney commented 3 years ago

In GitLab by @ajscott860 on Jul 1, 2021, 09:59

It gets even weirder when using a cantrip weapon attack like Shillelagh. I can't explain what is happening here: (This attack would be based of the Quarterstaff weapon above for Fenric.)

Shil-Crit

tposney commented 3 years ago

The damage roll is 1d8 + 4 + 1d4, which ends up bieng 8 + 4 + 4 = 16. Why would you expect 19?

Ok, I think I understand. The max base damage is max base damage ONLY. No critical dice are rolled. If you want to max part of the roll the only option is max crit dice - which will be very close to what you want since the base dice (mostly are the same number as the crit dice).

tposney commented 3 years ago

The damage roll is 1d8+4. maxed to 8+4 = 12 I must be missing something since I can't see any problem with any of the rolls.

Ok, I think I understand. The max base damage is max base damage ONLY. No critical dice are rolled, like it says in the hint. If you want to max part of the roll the only option is max crit dice - which will be very close to what you want since the base dice (mostly are the same number as the crit dice).