tposney / midi-qol

Other
5 stars 0 forks source link

Saving throw and skill check issue since .8.73 update #569

Open tposney opened 2 years ago

tposney commented 2 years ago

In GitLab by @brazilopher on Oct 17, 2021, 11:00

Since updating to .8.73 saving throws for players and NPCs (using default sheets) haven’t worked, with the following error being thrown to the console:

foundry.js:7896

Uncaught (in promise) Error: Unresolved StringTerm NaN requested for evaluation

[Detected 2 packages: system:dnd5e, midi-qol]

at StringTerm.evaluate (foundry.js:7896)

at D20Roll._evaluate (foundry.js:5487)

at async d20Roll (systems/dnd5e/module/dice.js:252)

at async Actor5e.rollAbilitySave (modules/midi-qol/src/module/patching.js:274)

Skill checks also throw an error:

Uncaught (in promise) Error: Unresolved StringTerm [object Object] requested for evaluation

[Detected 2 packages: system:dnd5e, midi-qol]

at StringTerm.evaluate (foundry.js:7896)

at D20Roll._evaluate (foundry.js:5487)

at async Module.d20Roll (dice.js:252)

at async Actor5e.doRollSkill (patching.js:108)

Attacks and ability checks still seem to work.

This is using Foundry .8.9 and D&D 5e 1.5.2.

Enter the issue description

Sent from Mail for Windows

tposney commented 2 years ago

I can't repro this. Can you try with just midi-qol plus dependencies installed? Also export your midi-qol settings so that I can try and verify,

tposney commented 2 years ago

In GitLab by @brazilopher on Oct 17, 2021, 15:59

It appears to be tied with the Optional Rules for D&D5e module (I removed all mods and re-added one by one until this one caused the saves/skills to stop working). Specifically it looks like the Enable Proficiency Die Automation (this replaces the proficiency bonus with a die roll) as toggling this off allows saves/skills to work.

{

"configSettings": {

"gmAutoAttack": true,

"gmAutoFastForwardAttack": false,

"gmAutoDamage": "onHit",

"gmAutoFastForwardDamage": false,

"speedItemRolls": false,

"speedAbilityRolls": false,

"showItemDetails": "none",

"itemTypeList": [

"weapon",

"equipment",

"consumable",

"tool",

"loot",

"class",

"spell",

"feat",

"backpack"

],

"autoRollAttack": true,

"autoFastForward": "off",

"autoTarget": "wallsBlock",

"autoCheckHit": "all",

"autoCheckSaves": "allShow",

"hideRollDetails": "none",

"displaySaveDC": true,

"checkSaveText": true,

"autoRollDamage": "onHit",

"autoApplyDamage": "noCard",

"damageImmunities": "immunityPhysical",

"autoItemEffects": true,

"rangeTarget": "wallsBlockIgnoreDefeated",

"playerRollSaves": "letme",

"playerSaveTimeout": 0,

"rollNPCSaves": "letme",

"preRollChecks": false,

"mergeCard": true,

"mergeCardCondensed": true,

"hideNPCNames": "",

"useTokenNames": true,

"requireTargets": true,

"fumbleSound": "sounds/dice.wav",

"diceSound": "sounds/dice.wav",

"criticalSound": "sounds/dice.wav",

"itemUseSound": "",

"spellUseSound": "",

"weaponUseSound": "",

"potionUseSound": "",

"fullAuto": false,

"useCustomSounds": true,

"customSoundsPlaylist": "",

"keyMapping": {

"DND5E.Advantage": "altKey",

"DND5E.Disadvantage": "ctrlKey",

"DND5E.Critical": "altKey",

"DND5E.Versatile": "shiftKey"

},

"allowUseMacro": false,

"rollOtherDamage": "none",

"removeButtons": "all",

"gmRemoveButtons": "all",

"doReactions": "none",

"gmDoReactions": "none",

"reactionTimeout": 0,

"requiresTargets": "none",

"optionalRules": {

"invisAdvantage": true,

"checkRange": true,

"wallsBlockRange": "center",

"nearbyFoe": 5,

"nearbyAllyRanged": 4,

"incapacitated": true,

"removeHiddenInvis": true,

"maxDRValue": false,

"distanceIncludesHeight": false

},

"itemRollStartWorkflow": false,

"defaultSaveMult": 0.5,

"showReactionAttackRoll": "none",

"rollNPCLinkedSaves": "auto",

"requireMagical": true,

"concentrationAutomation": false,

"removeConcentration": false,

"singleConcentrationRoll": false,

"usePlayerPortrait": false,

"keepRollStats": false,

"saveStatsEvery": null,

"playerStatsOnly": false,

"soptionalRulesEnabled": false

},

"itemRollButtons": true,

"criticalDamage": "default",

"itemDeleteCheck": true,

"nsaFlag": false,

"coloredBorders": "none",

"addChatDamageButtons": "none",

"autoFastForwardAbilityRolls": false,

"autoRemoveTargets": "all",

"forceHideRoll": true,

"enableWorkflow": true,

"dragDropTargeting": true,

"flags": {

"exportSource": {

"system": "dnd5e",

"coreVersion": "0.8.9",

"systemVersion": "1.5.2"

},

"modules": {

"abouttimeVersion": "1.0.4",

"betterRollsVersion": "1.6.14",

"cubVersion": "1.6.2",

"daeVersion": "0.8.60",

"DSNversion": "4.2.1",

"dndhelpersVersions": "3.0.2",

"lmrtfyVersion": "1.20",

"midiQolVerson": "0.8.73",

"socketlibVersion": "1.0.9",

"simpleCalendarVersion": "v1.3.75",

"timesUpVersion": "0.8.19"

},

"all-modules": [

{

"name": "5e-statblock-importer",

"title": "5e Statblock Importer",

"description": "Import monster and NPC statblocks for D&D 5e",

"url": "https://github.com/jbhaywood/5e-statblock-importer",

"version": "1.2.2",

"minimumCoreVersion": "0.8.0",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"./scripts/sbi.js"

],

"socket": false

},

{

"name": "ATL",

"title": "Active Token Lighting",

"description": "Active Token Lighting",

"url": "https://github.com/kandashi/Active-Token-Lighting",

"version": "0.2.17",

"minimumCoreVersion": "0.8.3",

"compatibleCoreVersion": "0.8.8",

"scripts": [

"src/activeLighting.js"

],

"esmodules": [],

"socket": false

},

{

"name": "ActiveAuras",

"title": "Active-Auras",

"description": "Active-Auras",

"url": "https://github.com/kandashi/Active-Auras",

"version": "0.3.08",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"src/aura.js",

"src/AAhelpers.js",

"src/AAhooks.js",

"src/AAhtml.js",

"src/collateAuras.js",

"src/measureDistances.js",

"src/settings.js",

"src/templateDetection.js"

],

"esmodules": [],

"socket": true

},

{

"name": "Dynamic-Effects-SRD",

"title": "Dynamic Active Effects SRD",

"description": "DnD 5e SRD items, features and spells configured for Dynamic Active Effects, MQoL and AT",

"url": "https://github.com/kandashi/Dynamic-Effects-SRD",

"version": "6.0.01",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [],

"socket": false

},

{

"name": "EasyTable",

"title": "EasyTable by Blitz",

"description": "Creates simple text-based rollable tables from CSV (or any-SV) data",

"url": "https://github.com/BlitzKraig/fvtt-EasyTable",

"version": "1.3.3",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.6",

"scripts": [

"./easytable.js"

],

"esmodules": [],

"socket": false

},

{

"name": "_mathjs",

"title": "Math.js",

"description": "LIBRARY: Math.js - This module is just a dependency for other modules and does not offer any functionality on its own. This module includes the popular Math.js library.",

"url": "https://github.com/League-of-Foundry-Developers/mathjs-lib",

"version": "7.5.1-fvtt2",

"minimumCoreVersion": "0.0.0",

"compatibleCoreVersion": "1.0.0",

"scripts": [

"math.min.js"

],

"esmodules": [],

"socket": false

},

{

"name": "about-time",

"title": "About Time",

"description": "",

"url": "https://gitlab.com/tposney/about-time",

"version": "1.0.4",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"about-time.js"

],

"socket": true

},

{

"name": "advanced-macros",

"title": "Advanced Macros",

"description": "Use handlebars templating, recursive macro calls and call macros with arguments or directly from chat.",

"url": "https://github.com/League-of-Foundry-Developers/fvtt-advanced-macros",

"version": "1.11",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.6",

"scripts": [

"libs/hljs/highlight.pack.js",

"libs/tokenizer.min.js",

"module/Patches.js",

"Macros.js"

],

"esmodules": [],

"socket": true

},

{

"name": "award-xp",

"title": "Award XP",

"description": "Award Experience to the group, which will be devided between the players and automatically added their character sheets.",

"url": "https://github.com/manuelVo/foundryvtt-award-xp",

"version": "1.3.2",

"minimumCoreVersion": "0.8.2",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"src/main.js"

],

"socket": false

},

{

"name": "better-rolltables",

"title": "Better Roll Tables",

"description": "Adding functionality to roll tables, especially to roll treasure and magic items",

"url": "https://github.com/ultrakorne/better-rolltables",

"version": "1.8.3",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"./scripts/brt-main.js"

],

"socket": false

},

{

"name": "class-editor",

"title": "Class Leveling Editor",

"description": "",

"url": "https://github.com/ZoltanTheDM/class-editor",

"version": "0.5.0",

"minimumCoreVersion": "0.8.8",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"scripts/classEditor.js"

],

"socket": false

},

{

"name": "class-exposure",

"title": "Class Exposure",

"description": "",

"url": "https://github.com/ZoltanTheDM/Class-Exposure",

"version": "1.0.0",

"minimumCoreVersion": "0.8.8",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"class-exposure.js"

],

"socket": false

},

{

"name": "colorsettings",

"title": "lib - Color Settings",

"description": "Library that allows modules to add color settings and forms.",

"url": "https://github.com/ardittristan/VTTColorSettings",

"version": "2.8.1",

"minimumCoreVersion": "0.5.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"colorSetting.js"

],

"socket": true

},

{

"name": "combat-utility-belt",

"title": "Combat Utility Belt",

"description": "Adds various combat-focused features",

"url": "https://github.com/death-save/combat-utility-belt",

"version": "1.6.2",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"./library/typewriterjs/core.js"

],

"esmodules": [

"./combat-utility-belt.js"

],

"socket": false

},

{

"name": "compendium-browser",

"title": "Compendium Browser",

"description": "

Easily browse and filter spells, feats, items, and npcs loaded from compendia!

NEW! Compendium Browser is faster and better-behaved; it no longer loads all the compendia into memory on start-up (which sometimes hung servers because of memory or CPU requirements). Instead, it filters and loads on-demand, as well as giving you a Module Setting to control how many rows are loaded at a time.
Changes in 0.7.0: Supports Foundry 0.8+ only; faster searches using Foundry 0.8 queries!",

"url": "https://github.com/League-of-Foundry-Developers/compendium-browser",

"version": "0.7.1",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"./compendium-browser.js"

],

"esmodules": [],

"socket": false

},

{

"name": "compendium-folders",

"title": "Compendium Folders",

"description": "Collapsable folders for compendiums",

"url": "https://github.com/earlSt1/vtt-compendium-folders",

"version": "2.3.53",

"minimumCoreVersion": "0.8.2",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"./compendium-folders.js"

],

"socket": false

},

{

"name": "condition-automation",

"title": "Condition Automation",

"description": "A simple module to automaticly update token data based on status condtions",

"url": "https://github.com/kandashi/condition-automation",

"version": "3.0.2",

"minimumCoreVersion": "0.7.5",

"compatibleCoreVersion": "0.8.6",

"scripts": [

"scripts/complete.js",

"scripts/CApf1.js",

"scripts/CApf2.js",

"scripts/CAdnd5.js",

"scripts/CAmacro.js"

],

"esmodules": [],

"socket": false

},

{

"name": "custom-classes",

"title": "Custom Classes",

"description": "",

"url": "https://github.com/kandashi/custom-classes",

"version": "0.1.00",

"minimumCoreVersion": "0.7.9",

"compatibleCoreVersion": "0.8.3",

"scripts": [],

"esmodules": [

"/scripts/module.js"

],

"socket": false

},

{

"name": "dae",

"title": "Dynamic effects using Active Effects",

"description": "replacement for dynamic effects",

"url": "https://gitlab.com/tposney/dae",

"version": "0.8.60",

"minimumCoreVersion": "0.8.4",

"compatibleCoreVersion": "0.9.224",

"scripts": [

"libs/tokenizer.min.js"

],

"esmodules": [

"dae.js",

"module/patching.js"

],

"socket": true

},

{

"name": "dd-import",

"title": "Universal Battlemap Importer",

"description": "Imports scene elements from Universal VTT files generated by editors like DungeonFog and Dungeondraft",

"version": "2.2.0",

"minimumCoreVersion": "0.8.4",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"./ddimport.js"

],

"esmodules": [],

"socket": false

},

{

"name": "dfreds-droppables",

"title": "DFreds Droppables",

"description": "A FoundryVTT module that adds support for dropping folders onto the canvas.",

"url": "https://github.com/DFreds/dfreds-droppables",

"version": "1.3.1",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"./scripts/main.js"

],

"socket": false

},

{

"name": "dice-so-nice",

"title": "Dice So Nice!",

"description": "Adds the ability to show a nice 3D dice simulation when a roll is made.",

"url": "https://gitlab.com/riccisi/foundryvtt-dice-so-nice",

"version": "4.2.1",

"minimumCoreVersion": "0.8.4",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"./libs/cannon.min.js",

"./libs/select2.min.js"

],

"esmodules": [

"./main.js"

],

"socket": true

},

{

"name": "dlopen",

"title": "dlopen",

"description": "A library module contributed by The Forge for dynamically loading library dependencies into Foundry upon use.",

"url": "https://github.com/ForgeVTT/fvtt-module-dlopen",

"version": "1.0",

"minimumCoreVersion": "0.6.0",

"compatibleCoreVersion": "1.0.0",

"scripts": [

"./dlopen.js"

],

"esmodules": [],

"socket": false

},

{

"name": "dnd5e-helpers",

"title": "DnD5e Helpers",

"description": "Little helpers for little tasks.",

"url": "https://github.com/trioderegion/dnd5e-helpers",

"version": "3.0.2",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"/scripts/helpers.js"

],

"socket": true

},

{

"name": "downtime-ethck",

"title": "Ethck's 5e Downtime Tracking",

"description": "Adds a section to the character sheet to keep track of downtime activities.",

"url": "https://github.com/Ethck/Ethck-s-Downtime-Tracking",

"version": "0.6.1",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"training.js",

"downtime.js"

],

"socket": false

},

{

"name": "easy-target",

"title": "Easy Target",

"description": "Target tokens with alt+click.",

"url": "https://bitbucket.org/Fyorl/easy-target",

"version": "2.12",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.8",

"scripts": [

"main.js"

],

"esmodules": [],

"socket": false

},

{

"name": "foundry-combat-focus",

"title": "Combat Focus",

"description": "Shows the chat window on the combat tracker tab as well - no more switching between the two tabs during combat!",

"url": "https://github.com/Oromis/foundry-combat-focus",

"version": "1.4.1",

"minimumCoreVersion": "0.5.0",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"foundry-combat-focus.js"

],

"socket": false

},

{

"name": "foundryvtt-simple-calendar",

"title": "Simple Calendar",

"description": "A simple calendar module for keeping track of game days and events.",

"url": "https://github.com/vigoren/foundryvtt-simple-calendar",

"version": "v1.3.75",

"minimumCoreVersion": "0.7.9",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"./index.js"

],

"socket": true

},

{

"name": "game-icons-net",

"title": "Game-icons.net",

"description": "3800+ Icons from game-icons-net to use in your game. Browse to the Data/modules/game-icons-net/ directory for all your icon needs.",

"url": "https://github.com/datdamnzotz/icons/blob/master/README-FoundryVTT.md",

"version": "0.0.12",

"minimumCoreVersion": "0.0.5",

"compatibleCoreVersion": "0.9.0",

"scripts": [],

"esmodules": [],

"socket": false

},

{

"name": "give-item",

"title": "Give item to another player",

"description": "A module to allow players to give an item to another player",

"url": "https://github.com/Sepichat/FoundryVTT-GiveItem",

"version": "1.10.0",

"minimumCoreVersion": "0.8.0",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"scripts/main.js"

],

"socket": true

},

{

"name": "grouproll",

"title": "Group Roll Checks and Saves",

"description": "This module rolls skill and ability checks for groups of tokens.",

"url": "https://github.com/trdischat/grouproll",

"version": "0.8.4",

"minimumCoreVersion": "0.7.2",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"main.js"

],

"socket": false

},

{

"name": "healthEstimate",

"title": "Health Estimate",

"description": "Gives players ability to see approximate health status of a token",

"url": "https://github.com/mclemente/healthEstimate",

"version": "2.6.11",

"minimumCoreVersion": "0.8.4",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"./lib/chroma.min.js",

"./lib/color-picker.min.js",

"./lib/grapick.min.js",

"./lib/spectrum.min.js"

],

"esmodules": [

"./healthEstimate.js"

],

"socket": false

},

{

"name": "illandril-inventory-sorter",

"title": "Illandril's Inventory Sorter (5e)",

"description": "Automatically sorts actors' inventories alphabetically (currently only compatible with the DnD5e system).",

"url": "https://github.com/illandril/FoundryVTT-inventory-sorter",

"version": "1.1.3",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"./init.js"

],

"socket": false

},

{

"name": "illandril-third-pact",

"title": "Illandril's Pact Slot Third Caster (5e)",

"description": "Adds support for Third Caster subclasses that use Pact Magic, and allows d4 and d20 options for hit dice.",

"url": "https://github.com/illandril/FoundryVTT-third-pact",

"version": "1.2.4",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"./scripts/index.js"

],

"socket": false

},

{

"name": "initiative-double-click",

"title": "Initiative Double Click",

"description": "Double click the initiative value in the combat tracker to quickly modify it.",

"url": "https://github.com/League-of-Foundry-Developers/fvtt-initiative-double-click",

"version": "1.2",

"minimumCoreVersion": "0.8.4",

"compatibleCoreVersion": "0.8.8",

"scripts": [

"Combat.js"

],

"esmodules": [],

"socket": true

},

{

"name": "journal-icon-numbers",

"title": "Automatic Journal Icon Numbers",

"description": "Automatically pick numbered icons for journal icons added to the map. Supports numbers 0-999, with an option prefix or postfix of a single letter. Different icon styles can be selected in the config menu.",

"url": "https://gitlab.com/tiwato/journal_icon_numbers",

"version": "v1.5.3",

"minimumCoreVersion": "0.8.0",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"src/index.js"

],

"socket": false

},

{

"name": "laptop-fix",

"title": "Laptop Form Fix",

"description": "Fixes issues where a few apps(SceneConfig and Filepicker) will put the submit button off screen. Restructured html/css so that the submit button is always visible.",

"url": "https://github.com/wsaunders1014/laptop-fix",

"version": "0.0.8",

"minimumCoreVersion": "0.6.4",

"compatibleCoreVersion": "0.8.6",

"scripts": [

"laptop-fix.js"

],

"esmodules": [],

"socket": false

},

{

"name": "lessfog",

"title": "Less Fog",

"description": "This module allows adjustments to the appearance of the FOW.",

"url": "https://github.com/trdischat/lessfog",

"version": "0.8.6",

"minimumCoreVersion": "0.7.4",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"main.js"

],

"socket": false

},

{

"name": "lets-trade-5e",

"title": "Let's Trade 5e",

"description": "A Foundry VTT module which allows you to send and receive items from other players.",

"url": "https://github.com/KageJittai/lets-trade-5e",

"version": "0.3.0",

"minimumCoreVersion": "0.7.9",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"src/main.js"

],

"socket": true

},

{

"name": "lib-changelogs",

"title": "Changelogs",

"description": "Show changelogs of module in a non intrusive way.",

"url": "https://github.com/theripper93/libChangelogs",

"version": "0.4",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.8",

"scripts": [

"./scripts/changelogs.js",

"./scripts/showdown.js"

],

"esmodules": [],

"socket": false

},

{

"name": "lib-wrapper",

"title": "libWrapper",

"description": "Library for wrapping core Foundry VTT methods, meant to improve compatibility between packages that wrap the same methods.",

"url": "https://github.com/ruipin/fvtt-lib-wrapper",

"version": "1.10.8.0",

"minimumCoreVersion": "0.6.5",

"compatibleCoreVersion": "9.244",

"scripts": [],

"esmodules": [

"lib-wrapper.js"

],

"socket": false

},

{

"name": "lmrtfy",

"title": "Let Me Roll That For You!",

"description": "Ask your players to make rolls for you.",

"url": "https://github.com/League-of-Foundry-Developers/fvtt-module-lmrtfy",

"version": "1.20",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"./src/lmrtfy.js",

"./src/requestor.js",

"./src/roller.js"

],

"esmodules": [],

"socket": true

},

{

"name": "lootsheetnpc5e",

"title": "Loot Sheet NPC 5e",

"description": "This module adds an additional NPC sheet which can be used for loot containers such as chests or shopkeepers.",

"url": "https://github.com/jopeek/fvtt-loot-sheet-npc-5e",

"version": "3.2.1",

"minimumCoreVersion": "0.8.9",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"/lootsheetnpc5e.js"

],

"socket": true

},

{

"name": "macro-folders",

"title": "Macro Folders",

"description": "Collapsable folders for macros",

"url": "https://github.com/earlSt1/vtt-macro-folders",

"version": "1.2.23",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"./macro-folders.js"

],

"socket": false

},

{

"name": "magicitems",

"title": "Magic Items",

"description": "Module that adds the ability to create magical items with spells or feats that belong to the item itself, such as staffs or magic wands, which will be automatically inherited from the character who owns the item.",

"url": "https://gitlab.com/riccisi/foundryvtt-magic-items",

"version": "2.1.2",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"magicitems.js"

],

"socket": false

},

{

"name": "merchantsheetnpc",

"title": "Merchant Sheet NPC",

"description": "This module adds an additional NPC sheet which can be used for shopkeepers.",

"url": "https://github.com/whelan/fvtt-merchant-sheet-npc",

"version": "2.0.1",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"bundle.js"

],

"esmodules": [],

"socket": false

},

{

"name": "midi-qol",

"title": "Midi QOL",

"description": "Automates rolling weapon/spell attacks and applying damage",

"url": "https://gitlab.com/tposney/midi-qol",

"version": "0.8.73",

"minimumCoreVersion": "0.8.4",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"src/midi-qol.js"

],

"socket": true

},

{

"name": "midi-srd",

"title": "Midi SRD",

"description": "DnD 5e SRD items, features and spells configured for Dynamic Active Effects and Midi QoL",

"url": "https://github.com/kandashi/midi-srd",

"version": "0.1.02",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [],

"socket": false

},

{

"name": "monsterblock",

"title": "Monster Blocks",

"description": "An NPC sheet designed to emulate standard 5e monster stat blocks as faithfully as possible.",

"url": "https://github.com/zeel01/MonsterBlocks",

"version": "3.1.1",

"minimumCoreVersion": "0.8.8",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"input-expressions/handler.js"

],

"esmodules": [

"monsterblock.js"

],

"socket": false

},

{

"name": "multilevel-tokens",

"title": "Multilevel Tokens",

"description": "

Adds several helpful token automation features, particularly (but not only) suited to maps with multiple levels.

Teleport tokens to another location when they move into a particular region (e.g. from the bottom of a staircase to the top). Clone tokens from one region to another, syncing movement and other property updates (e.g. allowing players to \"see\" what is happening on floors below). Trigger macros when a token enters or leaves a particular region.

See page at URL below for full usage instructions.

",

"url": "https://github.com/grandseiken/foundryvtt-multilevel-tokens",

"version": "1.5.2",

"minimumCoreVersion": "0.8.7",

"compatibleCoreVersion": "0.8.8",

"scripts": [

"multilevel.js"

],

"esmodules": [],

"socket": true

},

{

"name": "optional-rules-dnd5e",

"title": "Optional Rules for Dnd5e",

"description": "This module aims to automate some of the optional and homebrew rules avaialable for DnD 5e. Do note that you will still require the original source books to reference the full set of rules.",

"url": "https://github.com/NekroDarkmoon/optional-rules-dnd5e",

"version": "0.2.8",

"minimumCoreVersion": "0.8.5",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"index.js"

],

"socket": false

},

{

"name": "sheet-macro",

"title": "Actor Sheet Macro",

"description": "Drag actors to the macro bar to create a macro that opens their sheet.",

"url": "https://bitbucket.org/Fyorl/sheet-macro",

"version": "1.3",

"minimumCoreVersion": "0.5.5",

"compatibleCoreVersion": "0.8.8",

"scripts": [

"main.js"

],

"esmodules": [],

"socket": false

},

{

"name": "sheet-to-token",

"title": "Sheet To Token",

"description": "Automatically updates an actor's Prototype Token to use the same image set for the actor",

"url": "https://gitlab.com/brunhine/foundry-SheetToToken",

"version": "0.1",

"minimumCoreVersion": "0.5.5",

"compatibleCoreVersion": "0.5.5",

"scripts": [],

"esmodules": [

"sheet-to-token.js"

],

"socket": false

},

{

"name": "simple-worldbuilding-plus",

"title": "Simple World-building Plus",

"description": "Adds TinyMCE enhancements useful for building character sheets with the Simple World-building system.",

"url": "https://gitlab.com/asacolips-projects/foundry-mods/simple-worldbuilding-plus",

"version": "1.0.0",

"minimumCoreVersion": "0.7.0",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"module/simple-worldbuilding-plus.js"

],

"socket": false

},

{

"name": "socketlib",

"title": "socketlib",

"description": "A library for easier handling of foundry sockets",

"url": "https://github.com/manuelVo/foundryvtt-socketlib",

"version": "1.0.9",

"minimumCoreVersion": "0.7.9",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"src/libwrapper_shim.js",

"src/socketlib.js"

],

"socket": false

},

{

"name": "spellTemplateManager",

"title": "Spell Template Manager",

"description": "A simple module for automatically removing spell templates when spell duration is completed. Also maintains a single concentration spell per character. Optionally supports the About Time module for handling of timing.",

"url": "https://github.com/bitkiller0/spellTemplateManager",

"version": "2.1.3",

"minimumCoreVersion": "0.8.6",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"scripts/spellTemplateManager.js",

"scripts/Hooks.js",

"scripts/settings.js",

"scripts/stmData.js",

"scripts/stmUtils.js",

"scripts/textures.js",

"scripts/UI.js",

"scripts/UIPatches.js"

],

"socket": false

},

{

"name": "spellbook-master",

"title": "Spellbook Master",

"description": "This module simplifies the process of creating spellbooks from actors that have spells. Now, creating a spellbook, is as simple as pressing a button and a new item, that has all the spells of the owner actor, will appear in the items tab.",

"url": "https://github.com/HadaIonut/spellbook-master",

"version": "1.0.4",

"minimumCoreVersion": "0.8.2",

"compatibleCoreVersion": "0.8.3",

"scripts": [],

"esmodules": [

"scripts/spellbook-master.js"

],

"socket": false

},

{

"name": "split-journal",

"title": "Split Journal",

"description": "Split journal entries into multiple entries.",

"url": "https://github.com/League-of-Foundry-Developers/fvtt-split-journal",

"version": "1.1",

"minimumCoreVersion": "0.8.4",

"compatibleCoreVersion": "0.8.6",

"scripts": [

"libs/split-html.js",

"Entities.js"

],

"esmodules": [],

"socket": true

},

{

"name": "tabbed-chatlog",

"title": "Tabbed Chatlog",

"description": "Splits the Chatlog into In Character (per scene), Rolls (per scene), and Out of Character (global).",

"url": "https://github.com/cswendrowski/FoundryVTT-tabbed-chatlog",

"version": "1.6.3",

"minimumCoreVersion": "0.8.0",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"./tabbed-chatlog.js"

],

"socket": false

},

{

"name": "times-up",

"title": "times-up",

"description": "Active expiry expiration",

"url": "https://gitlab.com/tposney/times-up",

"version": "0.8.19",

"minimumCoreVersion": "0.8.2",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"times-up.js"

],

"socket": true

},

{

"name": "token-action-hud",

"title": "Token Action HUD",

"description": "Creates a HUD showing a selected token's common actions.",

"url": "https://github.com/Drental/fvtt-tokenactionhud",

"version": "1.3.13",

"minimumCoreVersion": "0.8.0",

"compatibleCoreVersion": "0.8.9",

"scripts": [

"./lib/tagify/tagify.min.js",

"./scripts/bundle.min.js"

],

"esmodules": [],

"socket": false

},

{

"name": "variant-encumbrance-dnd5e",

"title": "Variant Encumbrance+Midi",

"description": "A module for D&D 5th Edition, to automatically modify character carry weights to match the Variant Encumbrance optional rule set.",

"url": "https://github.com/VanirDev/VariantEncumbrance",

"version": "0.5.19",

"minimumCoreVersion": "0.7.10",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"VariantEncumbrance.js"

],

"socket": true

},

{

"name": "wild-magic-surge-5e",

"title": "Wild Magic Surge 5e",

"description": "A module to remind you whenever a player with the Wild Magic Surge Feat casts a spell and to roll a d20.",

"url": "https://github.com/johnnolan/wild-magic-surge-5e",

"version": "1.3.1",

"minimumCoreVersion": "0.8.9",

"compatibleCoreVersion": "0.8.9",

"scripts": [],

"esmodules": [

"/scripts/module.js"

],

"socket": false

},

{

"name": "xml-import",

"title": "XML import",

"description": "",

"url": "https://github.com/ZoltanTheDM/XML-foundry-import",

"version": "0.6.2",

"minimumCoreVersion": "0.8.8",

"compatibleCoreVersion": "0.8.8",

"scripts": [],

"esmodules": [

"scripts/xml-import.js"

],

"socket": false

}

]

}

}

... Sent from [Mail](https://go.microsoft.com/fwlink/?LinkId=550986) for Windows From: [Tim Posney (@tposney)](mailto:gitlab@mg.gitlab.com) Sent: Saturday, October 16, 2021 9:14 PM To: brazilopher@gmail.com Subject: Re: midi-qol | Saving throw and skill check issue since .8.73 update (#569) [Tim Posney](https://gitlab.com/tposney) [commented](https://gitlab.com/tposney/midi-qol/-/issues/569#note_705609157): I can't repro this. Can you try with just midi-qol plus dependencies installed? Also export your midi-qol settings so that I can try and verify, — Reply to this email directly or [view it on GitLab](https://gitlab.com/tposney/midi-qol/-/issues/569#note_705609157). You're receiving this email because of your account on gitlab.com. If you'd like to receive fewer emails, you can [unsubscribe](https://gitlab.com/-/sent_notifications/REDACTED/unsubscribe) from this thread or adjust your notification settings.
tposney commented 2 years ago

For future reference it is better to attach settings as a file, rather than pasting.

I've experimented a bit and it seems that it is an interaction between optional-rules-dnd5e and dae. The patching that optional-rules does in the case of DAE being installed is out of date. I think this requires an update to optional-rules-dnd5e.

Until then I suggest disabling the proficiency dice feature. I can't really make changes for otional-rules. Can you raise the problem on the optional-rules site?