search

tposney / midi-qol

Other
5 stars 0 forks source link

3D dice roll don't roll on all devices with DsN enabled if canvas is off on the dice roller's settings #613

Open tposney opened 2 years ago

tposney commented 2 years ago

In GitLab by @ajaydacosta on Dec 3, 2021, 08:59

FVTT version: 0.8.9 Dice So Nice! version: 4.2.2 System: dnd5e 1.5.5 Better Rolls for 5E version: 1.6.16 midiQOL version: 0.8.85

Step to reproduce: Join on two devices. On device A, turn canvas off or turn 3d Dice from DsN off. Then roll dice from device A. no dice are rolled on Device B. Only when either BetterRolls for 5E is enabled, or when midiQOL is enabled, or both

these three modules, along with DAE & CUB, are some of the most popular 5e modules, and it would be great if low-power devices can be used just for character sheets while dice roll on the main battlemap on a tabletop TV (especially as we move back to in-person gaming)

linked to Better Rolls for 5E: https://github.com/RedReign/FoundryVTT-BetterRolls5e/issues/348 linked to DsN: https://gitlab.com/riccisi/foundryvtt-dice-so-nice/-/issues/263

tposney commented 2 years ago

I can't speak for better rolls, which, when enabled, is responsible for 3d dice display, not midi-qol.

However midi-qol will only generate 3d dice rolls if 3d dice is enabled on the client doing the roll.

tposney commented 2 years ago

In GitLab by @ajaydacosta on Dec 4, 2021, 14:16

The default for DsN is to roll on all clients, regardless of the dice rollers settings. Could I feature-request that for MidiQOL? Better Rolls is optional for me, so I can live without that being changed, but MidiQOL and DsN are but like, mandatory for 5E.

tposney commented 2 years ago

Unfortunately, the default DSN behaviour triggers by looking for a dice roll chat card being sent to chat and then reacting to that. You should see that behaviour with midi if you disable the merge card.

For Midi's merge card (and better rolls) the chat card sent is not a "roll" card. So the default DSN behaviour won't trigger. Instead Midi and BR need to trigger the roll themselves which means checking if DSN is enabled on the local client (I think).

I have not experimented what happens if DSN is not enabled locally and you trigger a 3d dice roll, but will have a look.

tposney commented 2 years ago

I tried something simple and it did not work. I think this will require a significant reorganisation of midi's dice so nice handling for it to work.

I will have a deeper look, but it might take a while.

tposney commented 2 years ago

In GitLab by @ajaydacosta on Dec 6, 2021, 05:30

Oh so just turning Merge Cards off fixes it! That's great for now :)