[Issue] Player Damage Card issues?

[tposney]

In GitLab by @ben.nelson.neb on Mar 29, 2022, 07:14

I was testing out the new "player damage card" and found minor issues (I think). The first image is a barbarian with rage getting hit with an epic fail of an attack, not sure if the calculation is correct since it should have been half-damage. Expected damage is 2, but it appears to be 1? This may or may not be an issue related to the enable feature or maybe I don't understand the math?

The next images show the barbarian attacking a skeleton with a maul to which it is vulnerable. The player damage card shows a strange calculation but shows 34 damage. The GM damage card shows the expected double damage of 68. Not sure if this was as intended? But the goal of showing the damage card was to show the actual damage applied. I like it doesn't show the HP of the NPC, but it is odd to see the calculation like that.

Another issue I ran into is that the buttons show no matter what option I choose for the players? Unless I messed something up?

I really like having this option, so thank you! Future suggestions around this item.

• The player damage card appears to show the GM name and time. If possible I would remove this line, damage card is great but it eats up the chat log space.
• Again to cut down on clutter, the "HP Updated" display on the player damage card also eats up a lot of space. I understand it needed for the GM, but not really for players. It would be nice to remove that header bar.
• If there is a concern with the player damage card not following up directly after the initial attack card, it might be good to show the attacker and target in one line. So the player damage card just shows a 1 line "{attacker} attacks {target} for {calculation}".

[tposney]

Thanks for the detailed description.

For the first case I would guess there is more than one resistance/effect at play (the tooltip for the creature hit should show any reistances/damage reduction etc). It's certainly possible there's a bug in the calculations, but every case I looked at ends up being something that someone did not remember being applied.

I don't think I understand the buttons question. The GM always gets the buttons, the players only get the buttons if the setting is enabled. Perhaps you mean the damage buttons on the item roll card? If so, that's set on the config settings panel (rather than the midi-settings panel).

The second case looks like the target had so many temp hp that no damage was done. Hence the -34 -> -0. I could not decide the best way to deal with temp hp - in the end I opted for treating it like resistance etc, damage just melts away. I'm open to suggestions as to what's a better solution.

As far as I know it's not possible to remove the the name and time. I think every chat card has them.
The HP Updated/not Updated is there for GMs who want players to apply their own damage. I can probably be a bit smarter about it and merge the options a bit so it is not required.
Maybe a solution is that the Player card should have the player's name at the top instead of Gamemaster (since something has to be there anyway).

[tposney]

In GitLab by @ben.nelson.neb on Mar 30, 2022, 01:39

Should have numbered them, sorry. For the first item, I think you are right, I will check if there is a double resistance at play. And also in the buttons, you are right again, I was seeing the buttons on the attack card. I am not sure what the button option is then?

As for the second item, the main purpose of this request is to show the actual damage which is hidden behind the scenes to the players. I don't think it is necessary to show the whole calculation to the players or even need to show the player damage card each time (just when it is different). But in the second case, the barbarian hit with a maul (bludgeoning) of 34 damage, due to the skeleton's vulnerability actually did 68 damage. which is reflected in the GM damage card but not in the player's card. As a player, if I hit a creature with a weapon and it does double damage I want to know! Sames goes if I hit a creature and it does nothing. Again this is about reflecting on what actually happened versus what my roll says I did.

The target in this case does have a lot of temp hit points for testing. But again, I wouldn't show HP, this is all about the actual damage, not the health.

Not sure on the rules with the name/time header, I saw multiple cards without it but that might be timing or some other factor. I would suggest the name of the attacker instead of the GM.

The "HP Update" on the player card just looks to be a waste of space and isn't needed. To keep it clean I would remove as much vertical clutter as possible.

I just notices the hover-over option over the icons showing DI/DR/DV, which is cool but isn't necessary and takes away the mystery of the target. I would remove that option or only show it on PC not NPC.

A suggestion of the Player Damage card visual:

[tposney]

There are cases when the hp updated is required, just not the ones you are looking at. If the setting includes show player buttons the display is necessary so that players know if they need to apply damage or not (the whole player card came about since in some games players want to apply their own damage by clicking a button).

I've changed it so that the hp updated line is only displayed if there is a PC in the list of targets and buttons are being displayed.

I'm not certain about the di/dr/dv - I can see an argument that says "Since you are showing the changed damage you should show why it is changed"

As for the double damage, again it all depends on your view of what temp hp are and I can see alternate interpretations which include if there are temp hp then no effective damage is done, i.e. they are analogous to Damage Reduction/absorption spells etc. But I don't have a strong view on the issue, so I'm going to count temp hp damage as damage for the card display

[tposney]

All of the changes should be "resolved" as best they will be in 0.9.43. If anything else comes up please reopen the issue