search

tproduit / pic2map

QGIS plugin for camera orientation and interaction between a picture and the map (monoplotting).
22 stars 5 forks source link

Insert polygon feature and drawing on monoplotter #9

Open sgindraux opened 4 years ago

sgindraux commented 4 years ago

Hi! These are requests instead of an issue...

Would it be possible to integrate a polygon feature in QGIS and display it on the monoplotter? (refresh layer). As you state in the documentation it is not possible yet but that would be very useful!!

Also would it be possible to draw th polygone on the monoplotter (instead of on the raster)? That also would be handy :-) For example I'd like to calculate the area of a chuck of ice on an oblique image and that would be much easier if I could draw it on the picture itself. (see example files).

If you don't want or don't have time to implement these, could you eventually give me hints where I should implement this in your code?

Cheers, Saskia

Screenshot (5) Screenshot (6)

frpin33 commented 4 years ago

Hello Saskia, Thanks for your interest in this plugin. Currently, I am not working on this plugin, so I can only guide you with your request. Maybe in 2 or 3 months I will be able to take a good look at both of your request.

If you want to draw polygon, you should start by adding it with refresh layer before trying to draw it on the Monoplotter. It will help you understand the code more I think, but that's just my opinion, you do what you want. It shouldn't be too hard to do since the code already exist, it just doesn't work at the moment. I'm not sure if it was working before on QGIS 2 version, but if it was, it should take you too long to fix. Check the function refreshLayers in monoplotterMainWindow.py at line 1290, everything should be there. The line is suppose to work but it doesn't sometime, so you can also check that if you want. The point doesn't seem to have an issue.

If you really want to draw on the monoplotter I can only give you some advice. Anything relate to the monoplotter are mostly in the file monoplotterMainWindow.py and ui_monoplotter.py (The ui is made with Qt). In the file ui there is a .ui for the monoplotter but he is outdated from the current version. If you want to draw on the monoplotter, you will probably need to understand QGIS for python and PyQt5. That probably also apply for the other solution. OpenGL could be helpfull, but I'm not so sure, I don't know that library very well but the original author use it at some places.

sgindraux commented 4 years ago

Hi!

Thank you so much for your answer :-) I also don't know if my employer will allow me to put time in this, but if I manage to make the changes, I'll keep you updated.

Thanks for keeping on working on that plugin! I find it great!

All the best, Saskia

-----"frpin33" notifications@github.com wrote: -----

======================= To: "tproduit/pic2map" pic2map@noreply.github.com From: "frpin33" notifications@github.com Date: 08/06/2019 03:16PM Cc: "SGindraux" saskia.gindraux@wsl.ch, "Author" author@noreply.github.com Subject: Re: [tproduit/pic2map] Insert polygon feature and drawing on monoplotter (#9)

Hello Saskia, Thanks for your interest in this plugin. Currently, I am not working on this plugin, so I can only guide you with your request. Maybe in 2 or 3 months I will be able to take a good look at both of your request.

If you want to draw polygon, you should start by adding it with refresh layer before trying to draw it on the Monoplotter. It will help you understand the code more I think, but that's just my opinion, you do what you want. It shouldn't be too hard to do since the code already exist, it just doesn't work at the moment. I'm not sure if it was working before on QGIS 2 version, but if it was, it should take you too long to fix. Check the function refreshLayers in monoplotterMainWindow.py at line 1290, everything should be there. The line is suppose to work but it doesn't sometime, so you can also check that if you want. The point doesn't seem to have an issue.

If you really want to draw on the monoplotter I can only give you some advice. Anything relate to the monoplotter are mostly in the file monoplotterMainWindow.py and ui_monoplotter.py (The ui is made with Qt). In the file ui there is a .ui for the monoplotter but he is outdated from the current version. If you want to draw on the monoplotter, you will probably need to understand QGIS for python and PyQt5. That probably also apply for the other solution. OpenGL could be helpfull, but I'm not so sure, I don't know that library very well but the original author use it at some places.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/tproduit/pic2map/issues/9#issuecomment-518664547