search

tpwd / ke_search

Search Extension for TYPO3 Content Management System, including faceting search functions.
https://extensions.typo3.org/extension/ke_search/
GNU General Public License v3.0
7 stars 31 forks source link

Hidden Header Fields are Indexed? #232

Closed aschoelling closed 1 month ago

aschoelling commented 2 months ago

Contrary to the documentation, it seems on our installation that header fields in tt_content which are set to "hidden" are still indexed. TYPO3 version 11.5.38 ks_search version 5.5.0 Case in point is a page that in it's source does not contain the word "XYZ", but does contain a single empty container element with the header containing "XYZ" and the header set to hidden.

Only a page indexer is used.

What am I missing here?

aschoelling commented 2 months ago

After some digging around, some more information on the problem: The content save by the indexer contains test not found on the page, neither in active nor in inactive content elements. Now I'm at a complete loss... . We're using the jar_rowcolumn extension and I'm seeing tons of "illegal value" errors as colPos for elements inside columnrow elements- does anybody have an idea on whether this might be the culprit?

christianbltr commented 1 month ago

ke_search checks if the header of a content element is set to hidden by looking at header_layout. If it is 100 (which is the "magic number" for a hidden header), the header is not indexed.

See https://github.com/tpwd/ke_search/blob/master/Classes/Indexer/Types/Page.php#L659

I don't think there's a bug in this particular function.

I'm not sure about jar_rowcolumn extension, I don't have any experience with it.

I'm closing this because I don't see a bug in ke_search here.

For general questions you may also try the TYPO3 Slack channel #ext-ke_search