tpwd / ke_search

Search Extension for TYPO3 Content Management System, including faceting search functions.
https://extensions.typo3.org/extension/ke_search/
GNU General Public License v3.0
7 stars 31 forks source link

[BUGFIX] Respect configured Doktypes while Auto-Tagging #235

Closed magicHatOfTYPO3 closed 1 month ago

magicHatOfTYPO3 commented 1 month ago

If Page Indexer has configured non-standard doktypes, respect them for auto-tagging.

Fixes #233

christianbltr commented 1 month ago

Thanks for the bugfix. Could you please have a look at the failed CI checks and fix them?

You are using preg_match() to check if the parameter contains a comma-separated list. While this should work totally fine I'm wondering if it would be better to use a combination of GeneralUtility:intExplode() and array_unique(). I see the following advantages:

magicHatOfTYPO3 commented 1 month ago

Hi @christianbltr ,

thanks for your reply. I agree, that GU:intExplode is the better option and have refactored the code.

christianbltr commented 1 month ago

Thanks!