tpwrules / nixos-apple-silicon

Resources to install NixOS bare metal on Apple Silicon Macs
MIT License
743 stars 73 forks source link

uboot-asahi: bug fixes and config updates #157

Closed zzywysm closed 3 months ago

zzywysm commented 4 months ago

https://github.com/jannau/u-boot-1/commits/apple-rtkit-boot-timeout/

https://github.com/jannau/u-boot-1/commits/asahi-vidconsole-fixes/

https://copr-dist-git.fedorainfracloud.org/cgit/@asahi/u-boot/uboot-tools.git/tree/0001-disable-NFS-support-by-default.patch?h=f39

These fixes have all been boot-tested successfully on my MacBook Air M1.

fx-chun commented 4 months ago

I like the boot logo. :(

zzywysm commented 4 months ago

I like the boot logo. :(

Then clearly you'll want to modify the line in this commit that reads CONFIG_VIDEO_LOGO=n to CONFIG_VIDEO_LOGO=y on your Mac.

In addition, if you really love submarines, you can change the boot logo in the middle of the screen from the Asahi Linux logo to your own PNG file of a magnificent submarine. Please refer to the boot.m1n1CustomLogo property.

zzywysm commented 3 months ago

@tpwrules Will you be reviewing this pull request, or shall I close it?

tpwrules commented 3 months ago

The bugfixes don't seem unreasonable, but they don't seem that necessary either.

I don't like how these PRs keep getting mixed with opinionated changes.

Let's wait til upstream releases a new U-Boot.

zzywysm commented 3 months ago

I don't like how these PRs keep getting mixed with opinionated changes.

To be clear, by "opinionated changes", you mean these opinions?

I didn't realize I was such a firethrower!

tpwrules commented 3 months ago

This persistent pattern of excessively opinionated changes, a sarcastic and one-sided attitude toward discussing them and their implications, and your style of interaction with me and other contributors, is difficult, stressful, and absolutely unwelcome.

You are free to make as many changes as you want to your own config and contribute your changes to the various upstreams, but I am no longer willing to tolerate your behavior and attitude.