tpwrules / nixos-apple-silicon

Resources to install NixOS bare metal on Apple Silicon Macs
MIT License
742 stars 73 forks source link

Fixes compilation on latest nixpkgs #175

Closed bkchr closed 3 months ago

bkchr commented 3 months ago

Closes: https://github.com/tpwrules/nixos-apple-silicon/issues/174

minego commented 3 months ago

I ran into the same issue, just did switched my flake to use this branch, and I can confirm that it does work correctly.

damien-rezdy commented 3 months ago

I forgot to report back, but I've detected no issue using unstable nixpkgs and @bkchr fork , for a day. And for a bit of context: the macbook running nixos on M1 is my work daily driver.

tpwrules commented 3 months ago

Had some work stuff so couldn't get to this immediately, thanks all for filing and testing!

tpwrules commented 3 months ago

@bkchr FYI the U-Boot fix was incorrect which ended up removing more flags than intended and breaking cross-compilation. See here: https://github.com/tpwrules/nixos-apple-silicon/commit/2aa408936e856f7ea76563cf438083162fba5476

Not a problem, just now we can update our intuition of how those functions work.

bkchr commented 3 months ago

Yeah I realized it as well yesterday, but didn't had the time to fix it! Ty!