search

tqch / ddpm-torch

Unofficial PyTorch Implementation of Denoising Diffusion Probabilistic Models (DDPM)
MIT License
197 stars 35 forks source link

Bug in target noise #2

Closed rahulvigneswaran closed 1 year ago

rahulvigneswaran commented 1 year ago

You are doing MSE(noise, predicted_noise). Shouldn't it be MSE(coef2*noise, predicted_noise)? https://github.com/tqch/ddpm-torch/blob/1bf0e5d178fa374d21f1a0a622bf61fbf3413d29/ddpm_torch/diffusion.py#L235

tqch commented 1 year ago

This is not a bug but is intended if you take a look at the pseudo code in the original paper and their official implementation link.