search

tqsd / QuNetSim

A quantum network simulation framework.
https://tqsd.github.io/QuNetSim/
MIT License
118 stars 52 forks source link

Fixed the bug of outdated function in eavesdropping on channel section #104

Closed pritamsinha2304 closed 3 years ago

pritamsinha2304 commented 3 years ago

Issue #79 Replaced the outdated sniffing function

stephendiadamo commented 3 years ago

Just small changes. Also could you change the file path to be pothole case?

pritamsinha2304 commented 3 years ago

I am sorry, if I mess up something while commit, merge etc., because this is my first open source contribution and also with Github

pritamsinha2304 commented 3 years ago

Just small changes. Also could you change the file path to be pothole case?

Can you tell what do you mean by "pothole case" ? I don't get it

stephendiadamo commented 3 years ago

pothole case

It just means something_like_this. All lowercase, spaces are _.

stephendiadamo commented 3 years ago

No problem, you did everything fine. Just small inconsistencies with the project style that I'd like you to change before I merge.

Thanks, Stephen

On Sun, 16 May 2021, 18:15 pritamsinha2304, @.***> wrote:

I am sorry, if I mess up something while commit, merge etc., because this is my first open source contribution and also with Github

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tqsd/QuNetSim/pull/104#issuecomment-841838852, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJDSBIPJIS337E7LKBIP3DTN7VRRANCNFSM446ZW6HQ .

pritamsinha2304 commented 3 years ago

pothole case

It just means something_like_this. All lowercase, spaces are _.

I changed it. I think I did it correctly

pritamsinha2304 commented 3 years ago

Sorry, very minor thing but can you change the filename to be all lowercase?

No problem