search

tr00per / googletest

Automatically exported from code.google.com/p/googletest
0 stars 0 forks source link

ASSERT_STRCASEEQ and ASSERT_STRCASENE macros should compare strings consistently across platforms #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently they use strcasecmp which is defined only for POSIX (or C) locale
in POSIX standard. We need consistent behavior across platforms to test for
internationalized code. strcoll might be appropriate to use.

Original issue reported on code.google.com by vladlosev on 30 Jun 2008 at 8:21

GoogleCodeExporter commented 9 years ago

Original comment by shiq...@gmail.com on 17 Sep 2008 at 9:44

GoogleCodeExporter commented 9 years ago

Original comment by shiq...@gmail.com on 30 Sep 2008 at 10:05

GoogleCodeExporter commented 9 years ago 
This could break existing code.  It's probably better to keep the existing 
behavior, 
and introduce some matchers to do what you suggest.

To make matchers more accessible, we can move them from gmock to gtest.

Original comment by zhanyong...@gmail.com on 22 Feb 2009 at 5:12

GoogleCodeExporter commented 9 years ago 
I plan to close this if no one objects in 5 days.

Original comment by zhanyong...@gmail.com on 22 Feb 2009 at 5:20

GoogleCodeExporter commented 9 years ago 
Not worth it.

Original comment by w...@google.com on 6 Mar 2010 at 6:03