search

tr00per / googletest

Automatically exported from code.google.com/p/googletest
0 stars 0 forks source link

Parameterized test compiles with warning #87

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create parameterized test under Linux
2. Compile with -W -Wall -Werror

What is the expected output? What do you see instead?
  Expect to see smooth compilation. Instead, get the following messages:

/usr/local/include/gtest/internal/gtest-param-util.h:487: warning: unused
parameter ‘file’
/usr/local/include/gtest/internal/gtest-param-util.h:487: warning: unused
parameter ‘line’

What version of the product are you using? On what operating system?
  gtest 1.2.0, gcc 4.1.2

Original issue reported on code.google.com by hin...@gmail.com on 16 Dec 2008 at 3:29

GoogleCodeExporter commented 9 years ago

Original comment by shiq...@gmail.com on 16 Dec 2008 at 11:41

GoogleCodeExporter commented 9 years ago 
These parameters will be used to fix issue 65.

Original comment by vladlosev on 20 Dec 2008 at 3:03

GoogleCodeExporter commented 9 years ago 
Vlad, why's this blocked by issue 65?  We could fix the warnings before we fix 
#65.

Original comment by shiq...@gmail.com on 22 Dec 2008 at 8:25

GoogleCodeExporter commented 9 years ago 
You are right, it doesn't really block it; it's purely convenience measure. 
Fixing
issue 65 will take care of this as well. Given that, and the fact that's not 
worth
spending separate cycles on it, I put 65 as a blocking issue. This way we'll be
reminded to close this issue once 65 is fixed. Feel free to remove the block if 
you
feel this is wrong.

Original comment by vladlosev on 22 Dec 2008 at 7:39

GoogleCodeExporter commented 9 years ago 
Marking this as "blocked by 65" gives people the wrong impression that we 
cannot do 
anything about this until 65 is fixed.  Since 65 is not an easy fix, we 
shouldn't let 
it block this for a long time.  Removing the block.

Original comment by zhanyong...@gmail.com on 22 Feb 2009 at 5:35

GoogleCodeExporter commented 9 years ago

Original comment by zhanyong...@gmail.com on 19 Jun 2009 at 12:29