ERR_DLOPEN_FAILED when launching compiled app

Auriosi commented 5 months ago

Works fine when I run the script using bun run, but when I compile into an executable, it fails. I can't find a way to include the dll in the output either. Any ideas? Running Windows 11 on Bun 1.1.4. Using basic example but url set to Google.

tr1ckydev commented 5 months ago

Yes, it's a known limitation of bun compile. You can't really include .dll files. It just bundles the source code and the package is trying to find the dll relative to it but it's not inside the bundle.

Though I had found a workaround long back and it still works. Because of this, I had always included another way to load dlls using WEBVIEW_PATH environment variable.

Extract the dll or just download from releases then inside a .env add that variable and the path then compile. It should work though the problem is that you'll need the dll file externally.

Im wondering if I can make this automatic, hence I'll be keeping this issue open.

Auriosi commented 5 months ago

Worked, thanks! I feel like it's a little out of the scope of this project, but any idea on how/if it's possible to hide the terminal window? I don't trust the people who will be using this, and I won't always be around them to remind them to not close the terminal.

tr1ckydev commented 5 months ago

Unfortunately there isn't any way yet to hide terminal unless bun fixes it or makes a way to do so.

redraskal commented 5 months ago

Worked, thanks! I feel like it's a little out of the scope of this project, but any idea on how/if it's possible to hide the terminal window? I don't trust the people who will be using this, and I won't always be around them to remind them to not close the terminal.

You can use editbin.exe from MSVC tools. The below powershell script will change the subsystem on an exe so the terminal will not show.

If you use Bun.spawn or node subprocess, "windowsHide" option is required to keep the terminal hidden.

$msvcPath = (& "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -latest -find "VC\Tools\MSVC" | Get-ChildItem | Select-Object -First 1 -ExpandProperty FullName)
$editbin = Join-Path -Path $msvcPath -ChildPath "bin\Hostx64\x64\editbin.exe"

Start-Process -FilePath $editbin -ArgumentList "/subsystem:windows", "program-here.exe" -NoNewWindow -Wait

Auriosi commented 5 months ago

vswhere was returning nothing, but I found editbin manually, ran from there. Thanks for your help!

blaconix commented 4 months ago

Bun 1.1.5 adds the ability to include .dll files in compile.

tr1ckydev commented 4 months ago

Great! But I was thinking how about putting the dll in a common place so that it doesn't need to be embedded and multiple apps can use it. The binary size will then be significantly smaller.

Even better if it uses system installed bun instead of embedding bun in the binary.

franklupo commented 4 months ago

what to specify in the file for embedded dll? best regards

redraskal commented 4 months ago

what to specify in the file for embedded dll? best regards

if you wanted to embed a dll, you could do something like this:

import lib from "./libwebview.dll" with { type: "file" };
import { dlopen } from "bun:ffi";

const symbols = dlopen(lib, {
...
});

aryzing commented 3 months ago

Not sure if I'm missing something? Just booted a vanilla project with bun 1.1.9 and webview-bun 2.0.0, getting the following error,

23 |     case "linux": lib_path += "libwebview.so"; break;
24 |     case "darwin": lib_path += `libwebview.${process.arch}.dylib`; break;
25 |     default: throw "unsupported platform: " + process.platform;
26 | }
27 | 
28 | export const lib = dlopen(process.env.WEBVIEW_PATH ?? lib_path, {
                        ^
ERR_DLOPEN_FAILED: Failed to open library. This is usually caused by a missing library or an invalid library path.
 syscall: "dlopen"

      at bun:ffi:61:41
      at /home/aryzing/workspace/aryzing/explore-webview-bun/node_modules/webview-bun/src/ffi.ts:28:20

Bun v1.1.9 (Linux x64)

Inside the build folder, the package successfully created libwebview.so.