search

tr1s / tris-webpack-boilerplate

A Webpack boilerplate for static websites that has all the necessary modern tools and optimizations built-in. Score a perfect 10/10 on performance.
https://twbp.tris.codes/
MIT License
1.02k stars 98 forks source link

Missing manifest file #8

Open Munter opened 5 years ago

Munter commented 5 years ago

Since this boilerplate already implements an offline strategy and already tries to improve the mobile display by using touch-icons, tile-images and theme colors, there should really be a web app manifest as part of the setup. https://developer.mozilla.org/en-US/docs/Web/Manifest

rubenaguadoc commented 5 years ago

Maybe #10 is useful for that.

tr1s commented 5 years ago

@Munter you make a fair point. I went all that way and then stopped at the manifest. Thank you @rubenaguadoc I'll go look into that pull request!

tr1s commented 5 years ago

I was playing around with it, but after some reading, I think I'm going to opt out of this still. The webpack-pwa-manifest is kind of abandoned, and I don't want to add extra complexity and confusion that might not get resolved in the future.

The idea here was that I'll prepare the boilerplate for people that want to take the full plunge into it themselves.

I'd consider adding in a barebones manifest.json for the sake of it, or if there's a more robust way to inject it that would be nice. I'll look into it more and feel to do the same and let me know your thoughts.

rubenaguadoc commented 5 years ago

Thank you for that. Definitely a PWA Manifest is neded to be somehow included. For me, the proposed package was nice because it handles all the icons and injects itself in the html. It's true that a barebones json file woud be much more easy and intuitive to configure, but we should figure out how to link it in all the htmls. (Hopefully autimatically, but manually adding one more tag in the head is not that much of a deal).