tr7zw / 3d-Skin-Layers

Renders the player skin layer in 3d
Other
178 stars 36 forks source link

Forge Version has Fabric API as dependency #143

Closed Einhornyordle closed 8 months ago

Einhornyordle commented 8 months ago

The latest version for (forge 1.6.2-1.20.1 - Forge) on Modrinth has Fabric API as required dependency

tr7zw commented 8 months ago

One guy makes an issue that one of my mods technically uses the fabric API without declaring it in the dependencies, and it just snowballs into so many dang issues 🙃

Einhornyordle commented 8 months ago

Makes sense for the fabric only version, since some launchers won't auto-install the fabric api, unless it is declared as a required dependency, but for the forge version, it just causes issues when forge tries to load the fabric api :sweat_smile:

tr7zw commented 8 months ago

Fixed manually for now. Will have to modify the build to not include the fabric mod info file in the forge builds, so mcpublish doesn't auto-add the fabric dependencies.

tr7zw commented 8 months ago

https://github.com/tr7zw/ProcessedModTemplate/commit/f12a24a656b46c3ba87518333715c083c717eca7 should fully fix this going forward.