Closed MATRIX-feather closed 4 months ago
Updated Version
Modified the version details in the settings.json
file by replacing the older "1.20.6-fabric"
with the new "1.21-fabric"
.
Method Changes in Mesh Interface
Updated the render
method in the Mesh
interface. The method will now be dealing with an int color
parameter. Any usage of float
parameters has been completely removed.
Added Empty Method
An empty addOptions()
method has been added in the ConfigScreenProvider.java
file. The purpose and use of this method will be clarified in future updates.
Method Modifications in CustomizableModelPart Class
render
method in the CustomizableModelPart
class. The updated version includes an int color
parameter, while getting rid of any float
parameters. This change is acccompanied by an appropriate modification in the method implementation.compile
method in the CustomizableModelPart
class underwent similar changes. The float
parameters have been removed in favor of a new int color
parameter.Method Update in CustomLayerFeatureRenderer Class
The renderLayers
method in the CustomLayerFeatureRenderer
class has been modified. The render
method call in the code will no longer be using the float
parameters.
Will check it later, rn still working on getting 1.21-Neoforge working and added to the modbase. Didn't have enough time last night and work rn.
The build seems to fail on 1.16.5. You can do a full local build with ./gradlecw build
and test versions with for example ./gradlecw :1.16.5-fabric:runClient
FYI, 1.21-forge and 1.21-neoforge should also now be valid targets, and if the 1.21-fabric code is done right, just work when added to the settings.json. Just try to keep it in the same order as the above versions, so
...
"1.20.6-forge",
"1.20.6-neoforge",
"1.20.6-fabric",
"1.21-forge",
"1.21-neoforge",
"1.21-fabric"
If they build they are probably fine, runClient currently doesn't work for forge/neoforge 1.20.6/1.21, so for testing the built jar needs to be thrown into a normal forge/neoforge setup.
I'm not sure if we should add them here, since this pr is for 1.21 fabric IMO
There is no reason just to do Fabric, as the code base is the same for all 3, and I only will release with all 3 done^^. Otherwise, I can accept the pr when it works and add the 2 lines myself. (assumed you just used Fabric for updating as NeoForge wasn't yet compiling correctly)
Done, Forge and NeoForge now added to the valid targets
Neat, will check it out in a moment. Just did EntityCulling(built worked, will test later), now looking into a glaring issue with FirstPerson and updating it to 1.21.
Btw also contact me on discord, will give you a contributor role etc.
Haven't tested compatibility with older Minecraft versions.
The old
render
method in CustomizableModelPart is kept for compat with mods calling this method (like ETF) so they won't need to update to use (unless they inject their code into this).