tr7zw / 3d-Skin-Layers

Renders the player skin layer in 3d
Other
188 stars 40 forks source link

Minecraft 1.21 #158

Closed MATRIX-feather closed 4 months ago

MATRIX-feather commented 4 months ago

Haven't tested compatibility with older Minecraft versions.

The old render method in CustomizableModelPart is kept for compat with mods calling this method (like ETF) so they won't need to update to use (unless they inject their code into this).

what-the-diff[bot] commented 4 months ago

PR Summary

tr7zw commented 4 months ago

Will check it later, rn still working on getting 1.21-Neoforge working and added to the modbase. Didn't have enough time last night and work rn.

tr7zw commented 4 months ago

The build seems to fail on 1.16.5. You can do a full local build with ./gradlecw build and test versions with for example ./gradlecw :1.16.5-fabric:runClient

tr7zw commented 4 months ago

FYI, 1.21-forge and 1.21-neoforge should also now be valid targets, and if the 1.21-fabric code is done right, just work when added to the settings.json. Just try to keep it in the same order as the above versions, so

...
        "1.20.6-forge",
        "1.20.6-neoforge",
        "1.20.6-fabric",
        "1.21-forge",
        "1.21-neoforge",
        "1.21-fabric"

If they build they are probably fine, runClient currently doesn't work for forge/neoforge 1.20.6/1.21, so for testing the built jar needs to be thrown into a normal forge/neoforge setup.

MATRIX-feather commented 4 months ago

I'm not sure if we should add them here, since this pr is for 1.21 fabric IMO

tr7zw commented 4 months ago

There is no reason just to do Fabric, as the code base is the same for all 3, and I only will release with all 3 done^^. Otherwise, I can accept the pr when it works and add the 2 lines myself. (assumed you just used Fabric for updating as NeoForge wasn't yet compiling correctly)

MATRIX-feather commented 4 months ago

Done, Forge and NeoForge now added to the valid targets

tr7zw commented 4 months ago

Neat, will check it out in a moment. Just did EntityCulling(built worked, will test later), now looking into a glaring issue with FirstPerson and updating it to 1.21.

tr7zw commented 4 months ago

Btw also contact me on discord, will give you a contributor role etc.