tr7zw / EntityCulling

Using async path-tracing to hide Tiles/Entities that are not visible
Other
235 stars 33 forks source link

1.7.10 Incompatibility between EntityCulling and Thaumcraft #144

Closed harvald closed 2 months ago

harvald commented 3 months ago

crash-2024-03-27_18.43.29-client.txt

Crash happened multiple times when entering nether, where wisps are in abundance. Stop crashing after removing EntityCulling mod.

tr7zw commented 3 months ago

java.lang.ClassCastException: thaumcraft.client.renderers.entity.RenderWisp cannot be cast to dev.tr7zw.entityculling.mixin.RenderLivingEntityAccessor at net.minecraft.client.renderer.entity.RenderManager.handler$zbj000$entityculling$doRenderEntity(RenderManager.java:531)

Uhhh I guess that is some side effect due to the Wisp not being a real entity. Should be easy to fix.

Brittank88 commented 3 months ago

In the meantime can this be fixed by whitelisting entity.Thaumcraft.Wisp (and entity.TwilightForest.Firefly for #145)?

Edit: Just realised that whitelist might be for blocks that you can actually see through - not sure.

tr7zw commented 2 months ago

Fixed with #145.