search

tr7zw / Exordium

There is no good reason to render the hotbar at 100+ fps
Other
229 stars 34 forks source link

Debug Overlay too dark #106

Open JustAlittleWolf opened 1 year ago

JustAlittleWolf commented 1 year ago

Hello, the debug overlay is way darker than the vanilla one (left buffer OFF, right buffer ON):

This was not an issue in exordium 1.1.4. Could this be due 568737d06ed3a3e0dd8ec48ead13b83b19cf5925?

tr7zw commented 1 year ago

This could be a result of rendering with the shader(rendering up to 8 textures at the same time in one render call). This was my first time working with hlsl shader code, and the blending of the alpha values is not as straightforward as expected https://github.com/tr7zw/Exordium/blob/1.20/Shared/src/main/resources/assets/minecraft/shaders/core/position_multi_tex.fsh . I'd say this is not a major issue, but a nice to fix if anyone knows how.

For reference, some indev screenshots of me fighting with the blending: These should have been the same colors: grafik grafik grafik grafik Kinda nuking the alpha of the scoreboard with the vignette: grafik

JustAlittleWolf commented 1 year ago

Oh right I see, that's a little more complicated to fix then

tr7zw commented 1 year ago

(Potentially the entire color could also be off, since the f3 gets rendered onto an empty texture. But that texture must have a color, even when its 100% transparent, afaik it should be black, but maybe having it white would be more correct, idk?)