tr7zw / Exordium

There is no good reason to render the hotbar at 100+ fps
Other
229 stars 34 forks source link

Update to 1.20.4 #131

Closed rybot666 closed 7 months ago

rybot666 commented 7 months ago

This PR updates Exordium to be compatible with 1.20.4

what-the-diff[bot] commented 7 months ago

PR Summary

Please note that several changes across files were made to remove unnecessary whitespaces and improve code readability, however, these do not impact functionality.

tr7zw commented 7 months ago

🤯 You are crazy 😅. I'll have to check it out later, since you used a different formatter(or maybe this project didn't have one setup yet), checking all 35 will take me a moment. If it's all fine and working I'll release it later today. Also, contact me on Discord (if you want).

tr7zw commented 7 months ago

Seems all good. Just realized that the formatted got introduced after the last change to the mod, that's why so much changed. The Forge version is broken as in 1.20.2, so I'll disable that part for the release.

R00tB33rMan commented 7 months ago

Ah yes, I decided to push someone to assist me with this mod's upgrade. Your mod is fantastic and I don't want to see it die :(

tr7zw commented 7 months ago

It's less die, I was just too unmotivated to sink much time into it, after the Forge version was a fail(hotbar doesn't update), and all the other compatibility issues with other mods. Additionally, in 1.20.5 Mojang reworked the UI logic to be less of a mess(but also requiring another rewrite of the core logic), so I was at a low point with this mod.

R00tB33rMan commented 7 months ago

It's less die, I was just too unmotivated to sink much time into it, after the Forge version was a fail(hotbar doesn't update), and all the other compatibility issues with other mods. Additionally, in 1.20.5 Mojang reworked the UI logic to be less of a mess(but also requiring another rewrite of the core logic), so I was at a low point with this mod.

That's fully understandable. I'd be happy to pull the same person or another contributor in to assist with this huge shift. I have a lot of people under my belt/available for contact and love using this mod to keep my game running smooth.