tr7zw / Exordium

There is no good reason to render the hotbar at 100+ fps
Other
229 stars 34 forks source link

[1.19.3] Incompatibility with Wynntils: Spell cast overlay turns hud half transparent #59

Open Commander07 opened 1 year ago

Commander07 commented 1 year ago

Expected results: https://user-images.githubusercontent.com/45269106/230149772-173905ea-466a-4a0d-a233-a33c3ad0780a.mp4

Actual results: https://user-images.githubusercontent.com/45269106/230149799-53ec6389-4608-4a4d-92df-6c1e83b49e1f.mp4

Steps to reproduce:

tr7zw commented 1 year ago

Just FYI, mod compatibility with other mods will not be worked on till after the next update(whenever I get around to that).

Frontear commented 1 year ago

can confirm, the aura spell of shaman is affected by exordium. Good to know it'll eventually be tackled though

tr7zw commented 1 year ago

Currently working on that new version. For people on 1.19.4 they can technically test that version by downloading it from the actions tab ( https://github.com/tr7zw/Exordium/actions?query=branch%3A1.19.4-dev ). So far I have done 0 testing on how it compares to the current release or mod compatibility. Maybe it's better, maybe it's worse.

Commander07 commented 1 year ago

Tested this version and the incompatibility is gone.

tr7zw commented 1 year ago

Hm thats good. Basically it now wraps each vanilla UI component into it's own buffer (chat, hotbar, health/hunger/armor, xp bar/level, scoreboard, f3 overlay). Then it only renders the buffer when there is a change in the content(like changing the slot, new chat message, changed health etc). This also adds more control to the options, letting you set a maximum frame rate for each part/disabling it entirely in case of incompatibility. In theory, this is faster than the old approach, but it also fully excludes mod added overlays like Wynntils/minimaps(which is a good thing for compatibility, but a bad thing for the fps).