search

tr7zw / FirstPersonModel

Enables the third person Model in firstperson
MIT License
130 stars 25 forks source link

Avatar heads are no longer hidden with Figura #431

Open Gakuto1112 opened 6 months ago

Gakuto1112 commented 6 months ago

Description

The head of the Figura avatar is no longer hidden in first person perspective in 2.3.4. This issue isn't occurred in 2.3.3 or older.

The screenshot that describes this issue

Figura is the skin mod that enables you replace your skin to what you like.

Reproduction method

  1. Install Fabric loader.
  2. Install this mod and Figura mod.
  3. Apply the avatar that replaces the vanilla model to the custom one (example).
  4. Look down in first person perspective with features of this mod enabled.
  5. You will see that the head will cover your vision.

Expected behaviors

The head of the avatar isn't rendered in first person perspective. In other words, it won't cover your vision when looking down. This behavior is the same as in 2.3.3 or older.

Environments

Item Version
Minecraft 1.20.4
Fabric Loader 0.15.7
Fabric API 0.96.4+1.20.4
First-person Model 2.3.4
Figura 0.1.4+1.20.4
tr7zw commented 6 months ago

Hm, the 2.3.4 was made to be more compatible and has better handling. Could be that Figura overwrites the method I hook in this case. Will have to check.

tr7zw commented 6 months ago

A few other things: Figura is and was never a supported mod, neither from my nor their end, as it does replace the player model. The simplest workaround, in any case, would be if Figure hides the head while First-person Mod is rendering(that's what the API is for). Also this issue seems to be either 1.20.4 Figura, or a Fabric issue, as I can reproduce it on Fabric 1.20.4, but not 1.20.1 Forge 🤔.

1.20.1 Forge with 1:1 the same versions of fpm and figura: grafik grafik grafik

tr7zw commented 6 months ago

Hm, it works fine on 1.20.4 Forge too, so its some issue with the Fabric version(that's a new one, usually it's Forge doing weird stuff). Will have to check what Figura does differently on Fabric.

Gakuto1112 commented 6 months ago

Thank you for confirming. I will bring this issue up to Figura developers.

Gakuto1112 commented 6 months ago

@UnlikePaladin, the Figura developer said that codes of both Figura Forge Edition and Fabric Edition are same.

We use the exact same code on Fabric and Forge They must be hiding the head differently on their end on Fabric

YOMA8338 commented 3 months ago

This also occurs in 1.20.6. I'm having a very hard time because the only version available for 1.20.6 is the one where this bug occurs.

tr7zw commented 3 months ago

Then you are talking about a different bug. This is about a Fabric compatibility issue with Figura.