search

tr7zw / FirstPersonModel

Enables the third person Model in firstperson
MIT License
129 stars 24 forks source link

Incompatibility/Suggestion in relation with Freecam Mod #443

Closed AzuryxxVortex closed 2 months ago

AzuryxxVortex commented 3 months ago

Hello! I have a problem where when using Freecam, the a default player is blocking any view.. image

which is how Freecam works, but I think something could be done for this.

If Freecam is activated, never render the player model.. This sounds easy to me, but I'm not sure how modding goes.

This is but a simple suggestion, hope it finds you well. Good day to everyone-

AzuryxxVortex commented 3 months ago

Oh, I see that it was fixed before, but it's back now in 1.20.1, mod version 2.3.4.

MattSturgeon commented 3 months ago

Original issue #291, fixed in this commit.

Current Freecam issue https://github.com/MinecraftFreecam/Freecam/issues/185, for reference.

Not sure yet if the issue is with FPM or Freecam, won't be able to investigate for at least a few days either.

AzuryxxVortex commented 3 months ago

Issue is present on all 1.20.1 versions of FPM and Freecam, My guess is that the fix was lost in 1.20+ maybe...

I've tested from FPM 2.2.3 to 2.3.4, and none work correctly alongside Freecam I'm afraid

AzuryxxVortex commented 3 months ago

I figured it out! The commit was only for the fabric version of the mod, as the file address stated, and it was never present in the forge port.

Thank you @MattSturgeon for pointing out the commit, I wouldn't have found that otherwise.

So, it's fixed for fabric, but not forge.

MattSturgeon commented 3 months ago

I noticed FPM has a compile-only dependency on Freecam's fabric build. This is used to check Freecam.isEnabled().

That dependency should also work fine for forge/neoforge, so long as you don't reference any non-common classes, such as FreecamFabric or ModMenuIntegration, and you don't need a runtime dependency. You could use the forge version if you prefer though.

@tr7zw Hopefully enabling your existing fix in Forge builds will be fairly simple and resolves the issue. I don't currently have time to do a PR though.

AzuryxxVortex commented 2 months ago

This still hasn't been fixed sadly, and newer version of this mod entirely bans Sinytra, telling me to switch to forge- Cannot however because it still has the compatibility issue..