tr7zw / FirstPersonModel

Enables the third person Model in firstperson
MIT License
111 stars 21 forks source link

Incompatibility with Better Combat mod in Dynamic Mode #453

Open damikdevil opened 1 month ago

damikdevil commented 1 month ago

Forge 47.2.32, Minecraft 1.20.1 Latest version of First Person mod and Better Combat When vanilla hands and dynamic mode are enabled better combat animations when you look up dissapearing and you just using vanilla combat

tr7zw commented 1 month ago

Yea good chance for that not to work. Don't try to combine these features for now.

Straticus commented 1 month ago

will there be compatibility for this in the future. ive known this to be an issue forever. i was told by the developer of better combat that he will not be fixing it. would be great if this was compatible

tr7zw commented 1 month ago

Just turn off dynamic mode. It's a new feature, no it's not compatible(for now).

Straticus commented 1 month ago

i meant that a long time ago before dynamic mode existed, i tried to combine better combat with first person using the vanilla hands only mode which removed the rendering of the arms but kept the body. I wanted a hybrid vanilla experience with vanilla arms but having the ability to look down at my body. still the same issue back then.

tr7zw commented 1 month ago

Then why mention dynamic mode in the first place when you mean vanilla hands?

damikdevil commented 1 month ago

Then why mention dynamic mode in the first place when you mean vanilla hands?

It was me

Straticus commented 1 month ago

Yeah there's two different people in this thread lol

tr7zw commented 3 weeks ago

Ah, same no icon, didn't notice that 😅

tr7zw commented 3 weeks ago

https://github.com/ZsoltMolnarrr/BetterCombat/pull/370 fix in here

Straticus commented 3 weeks ago

i usually was going to just play with the vanilla hands only without dynamic mode, so for me, as long as the issue of the rendering of the animations for vanilla hands is fixed, then its perfect. how do i download the updated files?

tr7zw commented 3 weeks ago

You'll have to wait for the fix to be implemented in BetterCombat, or build that version yourself, as it doesn't have CI setup.