search

tr7zw / FirstPersonModel

Enables the third person Model in firstperson
MIT License
132 stars 25 forks source link

feat request: option to adjust dynamic transition angles #455

Open Novaenia opened 4 months ago

Novaenia commented 4 months ago

sometimes you can end up looking at such an angle that the vanilla hand is still present but way too low, especially when placing blocks in front of you which can look rather strange. an option to change the specific angle values the transition is done in would be nice, as well as a minimum transition time so the hand doesn't just pop in/out when the min/max angles are set to the same value.

tr7zw commented 4 months ago

I'm not sure I can follow. Are we talking about vanilla hands with dynamic hands? The transition point there is picked based on when the item is already going offscreen, in addition to moving the arm down so the transition can't be seen. Changing that transition point would just make it more obvious or there would be a big gap in the angles where you cant see the transition at all.

tr7zw commented 4 months ago

Not sure what you mean with transition time, as time is not used at all for this, purely angle-driven.

Novaenia commented 4 months ago

Not sure what you mean with transition time, as time is not used at all for this, purely angle-driven.

I'm aware, but if the user were to change the window size to 0° then there would no longer be any room for a visible transition hence a flat time would be needed.

instead of altering the transition point/size, what about changing the transition to interpolate the item model (and Z depth) between its first-person and third-person versions? look at the current transition when holding a sword: transition the sword ducks out of view entirely. intended, but it still seems rather odd. looking at both states side-by-side: image you could imagine another image in-between, in which the sword is in-between those two locations - that would be a far more natural transition than the current one, if done well.