search

tr7zw / ItemSwapper

Tweaks to the inventory system based on Xisumavoid's video.
Other
100 stars 30 forks source link

[BUG] Disabling on one server disables on all #149

Open Cameron-Witcher opened 1 year ago

Cameron-Witcher commented 1 year ago

Version information

itemswapper-fabric-0.4.0-mc1.19.4

Other relevant installed mods

modmenu-6.1.0-rc.4

Expected Behavior

Should be enabled on servers you've allowed it on, and only disabled on servers you've selected to disable it on.

Actual Behavior

Is enabled until disabled on another server. Then is disabled on all servers.

Reproduction Steps

Requirements: 2 servers (A and B)

  1. Join server A.
  2. Enable ItemSwapper
  3. Use ItemSwapper
  4. Leave Server A
  5. Join Server B
  6. Disable ItemSwapper
  7. Leave Server B
  8. Join Server A
  9. Use ItemSwapper
  10. Get message "You have disabled ItemSwapper on this server"

Render engine

Additional information

No response

tr7zw commented 1 year ago

Hm, this sounds like the locale state isn't correctly reset. Will look into it.

tr7zw commented 1 year ago

As an fyi, I did look into this during the last updates, and at least code wise I didn't see anything wrong(flags should reset correctly). Will have to create a setup to further test it.