search

tr7zw / ItemSwapper

Tweaks to the inventory system based on Xisumavoid's video.
Other
98 stars 27 forks source link

Bug/Feature - Setting opening time for ItemSwapper & Clicking empty space on toggle mode would close UI #173

Open Mudxiej opened 11 months ago

Mudxiej commented 11 months ago

Is your feature request related to a problem?

  1. So ItemSwapper has a bug where if you have empty hand it takes kinda long time to open the inventory. A way to set the length of its opeing would be useful.
  2. Also - on toggle mode - when player would click the empty space the UI would close

Describe the solution you'd like

  1. Creating a posibility to set the length of opening the inventory
  2. Just press empty space = close, idk why i need to explain this XD

Describe alternatives you've considered

  1. just fix the bug (if its a bug) or just make a slider to set the time

Additional context

Well... idk - message sth back? It's just a simple idea and if I at least could hear what do you thing about it - LMK

tr7zw commented 9 months ago

1) Not sure what you mean? 2) Hm will have to check how much of change that would require.

tr7zw commented 9 months ago

Actually, I think it might be more interesting to treat clicking an empty slot as a swap request. So you can use it to put items away from the hand/into shulkers.

Mudxiej commented 9 months ago

long time ago reported so im just calling back from the memories:

  1. when i have empty hand it isnt opening instantly when i press the button, when i do have an item - then it opens
  2. just bc im just checking my inventory and eg. i dont have an item so i want to close it, but not to swap any items I will record a vid about those 2 problems tmr (if my MC instance still works XD)
tr7zw commented 9 months ago

1) hm, nothing since then changed, but I also don't see any delay, so not sure. 2) Yeah, but I think this would be more intuitive(and add more functionality for everyone). Maybe clicking outside of the UI could close it for toggle mode? (Also there is the same key you used to open it, and esc to close it, so making switching into empty slots impossible for a 3rd way to close sounds meh).

Mudxiej commented 9 months ago

I will provide you with a vid tmr. Dont worry :))

Mudxiej commented 9 months ago

Well sorry for long absence - but I sadly cannot show this to you, bc my minecraft broke. I have 100+ vanilla mods and they broke my 1.20.1 ver of minecraft, and somehow i cannot turn it on. But as i remember:

  1. the button im using is page up (i have 12 buttons on the side) and the time it gets to load it up takes some time?
  2. I mean i thought if i hold the item, and would click empty slot the item swapper would close, not removing the tool? also maybe compatibility w ith inv profiles next, so locked slots wont get swapped?